Skip to content

fix: correct various issues with gym v21 compatibility env & update CI to work - #152

Merged
Trenza1ore merged 7 commits into
Farama-Foundation:mainfrom
Trenza1ore:main
Jul 10, 2026
Merged

fix: correct various issues with gym v21 compatibility env & update CI to work#152
Trenza1ore merged 7 commits into
Farama-Foundation:mainfrom
Trenza1ore:main

Conversation

@Trenza1ore

@Trenza1ore Trenza1ore commented Jul 10, 2026

Copy link
Copy Markdown
Member

Description

  1. Improve Gym v21 protocol correctness (gym.Env.seed returns list[int] | None)
  2. Call super().reset(seed=seed) in Gym v21 reset
  3. Fix various issues with unit tests & CI

Fixes #147

Also opened this PR in upstream project dm_control:

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Trenza1ore
Trenza1ore merged commit 5d1aee2 into Farama-Foundation:main Jul 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please fix CI on main

1 participant