Skip to content

Apply accessors with greatest visibility first #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kevinthegreat1 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Apply accessors with greatest visibility first #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/org/spongepowered/asm/mixin/transformer/MixinApplicatorStandard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,10 @@ protected void applyInjections(MixinTargetContext mixin, int injectorOrder) {
*/
protected void applyAccessors(MixinTargetContext mixin) {
List<MethodNode> accessorMethods = mixin.generateAccessors();

// Apply greatest visibility first
accessorMethods.sort(Comparator.<MethodNode>comparingInt(m -> Bytecode.getVisibility(m).ordinal()).reversed());

for (MethodNode method : accessorMethods) {
if (!method.name.startsWith("<")) {
this.mergeMethod(mixin, method);
Expand Down
Loading