Make the module-info work in more generic scenarios - #209
Open
Geolykt wants to merge 1 commit into
Open
Conversation
This commit allows fabric's Mixins and MixinExtras to be run in a JPMS environment such as Stianloader's SLL. For use outside of modlauncher, a potemkin/facade is required that provides requested modlauncher packages and modules. Compatibility with modlauncher not tested, though I don't expect something to break due to this commit on this front.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows fabric's Mixins and MixinExtras to be run in a JPMS environment such as Stianloader's SLL.
For use outside of modlauncher, a potemkin/facade is required that provides requested modlauncher packages and modules.
Compatibility with modlauncher not tested, though I don't expect something to break due to this commit on this front.
The
openmodule is required due to MixinExtras using reflection whilst not having a stable module name. Technically we could depend on a automatically generated name such asmixinextras.common, but that is not exactly future-proof.