always use fixed order of name and type in nyaml - #64
Merged
Conversation
lukaspie
force-pushed
the
name-and-type-order
branch
from
February 28, 2025 11:44
5b40625 to
ee90073
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in FAIRmat-NFDI/nexus_definitions#332 (comment), we should have a consistent way of writing the name and the type for a given concept.
Namely, it should be
name(type), i.e.sensor(NXsensor)and not(NXsensor)sensor, independent of what comes first in the NXDL file. Note that there is no order to the XML attributes anyway, so the enforced structure that was implemented before this PR doesn't really make sense.