Skip to content

Changes from mpes workshop - #32

Closed
domna wants to merge 2 commits into
fairmatfrom
mpes-workshop
Closed

Changes from mpes workshop#32
domna wants to merge 2 commits into
fairmatfrom
mpes-workshop

Conversation

@domna

@domna domna commented May 12, 2023

Copy link
Copy Markdown

No description provided.

Comment thread contributed_definitions/nyaml/NXmpes.yaml Outdated
start_time(NX_DATE_TIME):
doc: "Datetime of the start of the measurement."
end_time(NX_DATE_TIME):
exists: recommended

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see also my comments in the NXmpes_xps PR:
#30 (comment)

unit: NX_ANY
(NXelectronanalyser):
description:
model(NXfabrication):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe manufacturer, model, and serial number could be recommended here.

\@version:
enumeration: ["NXmpes"]
enumeration: ["NXmpes"] # ISO 18115
method: # ISO 18115

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a proper doc string

@domna
domna marked this pull request as draft June 1, 2023 15:45

@sanbrock sanbrock left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add doc string to ISO based method

@domna domna mentioned this pull request Aug 9, 2023
@sanbrock

Copy link
Copy Markdown

domna added a commit that referenced this pull request Sep 13, 2023
@domna

domna commented Sep 13, 2023

Copy link
Copy Markdown
Author

Closing this in favour of #52

@domna domna closed this Sep 13, 2023
domna added a commit that referenced this pull request Sep 25, 2023
domna added a commit that referenced this pull request Oct 5, 2023
@lukaspie
lukaspie deleted the mpes-workshop branch March 26, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants