Repository navigation
fix(lab-gate): report a gate that printed nothing by its exit code and resource-guard verdict - #18504
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Lab gate job that ends before
gate-executeprints anything was reported as a receipt parse error:That buried the real cause. In runner job
58a52bd1(Cookagent-task-a4a1fedf), the runner's resource guard had stopped the gate withresource_guard.process_count_limit_exceededand exit code 1. That verdict was already in the job's result event, undermetrics.guard_violation.Change
When the terminal gate stdout is empty, the transport returns a typed
runner.lab_transport_failurebefore attempting to parse:exit_codeandresource_guard(the violation), withgate_disposition: unavailable.The cause of this particular kill (
pids.maxset in the wrong unit) is fixed in #18503.Evidence
a_gate_that_printed_nothing_names_its_exit_and_resource_guardcovers both cases, guard verdict and stderr-only. It also checks the result is still classified as a Lab gate transport failure.-p homeboy-lab-runner --lib gate_transporton the Lab: 21/21.Written by Claude (claude-opus via Claude Code): traced from the Lab runner job events and implemented this change.