Repository navigation
fix(agent-task): settle cancellation for proven absent runner jobs - #18502
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consult the shared durable ledger before settling cancellation: multiple daemons share the HOME-scoped ledger, while each mirror contains only its own scope, so a mirror miss is not proof of absence.
What changed
Verification
cargo fmt --all -- --check: passed on
ae89676. Basemain@236eaceunchanged. 17086 ms; retained gate metadata.nice -n 10 cargo check --workspace --all-targets -j2: passed on
ae89676. Basemain@236eaceunchanged. 213942 ms; retained gate metadata.HOMEBOY_LINT_BASE=236eacef2b53585da813bf1ea5268893d56011b6 homeboy --placement l (
HOMEBOY_LINT_BASE=236eacef2b53585da813bf1ea5268893d56011b6 homeboy --placement local review lint homeboy --path . --cha…): passed onae89676. Basemain@236eaceunchanged. 320797 ms; retained gate metadata.repro: none (no repro gate was declared, so these gates do not prove the issue).
CI: pending
Cook run
4be41273ad1b0236609a106f63bd5022e21bfac84be41273ad1b0236609a106f63bd5022e21bfac84be41273ad1b0236609a106f63bd5022e21bfac8Evidence
AI disclosure
Tool: Homeboy Cook. Agent: Homeboy (pi). Model: Pi · route roadie/cook-heavy · served gpt-6.1-sol. Cook time: 15m16s.
Implementation and reviewer documentation were written by the AI, under the direction of the Cook requester. Gates were run by Homeboy. A human reviews before merge.
Closes #17479