Repository navigation
fix(runner): allow exact live-lease adoption despite stale freshness - #18501
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed freshness as a rejection criterion for explicit live-lease adoption while preserving all continuity checks and error messages.
What changed
Verification
cargo fmt --all -- --check: passed on
e67382d. Basemain@d909903advanced to28b0b93. 17003 ms; retained gate metadata.nice -n 10 cargo check --workspace --all-targets -j2: passed on
e67382d. Basemain@d909903advanced to28b0b93. 208124 ms; retained gate metadata.HOMEBOY_LINT_BASE=d909903f1d9fa682de5e2e652a61429fbec03010 homeboy --placement l (
HOMEBOY_LINT_BASE=d909903f1d9fa682de5e2e652a61429fbec03010 homeboy --placement local review lint homeboy --path . --cha…): passed one67382d. Basemain@d909903advanced to28b0b93. 316919 ms; retained gate metadata.repro: none (no repro gate was declared, so these gates do not prove the issue).
CI: pending
Cook run
0aa4bd967bb485891430b9395446c8e1a5a8b5180aa4bd967bb485891430b9395446c8e1a5a8b5180aa4bd967bb485891430b9395446c8e1a5a8b518Evidence
AI disclosure
Tool: Homeboy Cook. Agent: Homeboy (pi). Model: Pi · route roadie/cook-heavy · served gpt-6.1-sol. Cook time: 11m43s.
Implementation and reviewer documentation were written by the AI, under the direction of the Cook requester. Gates were run by Homeboy. A human reviews before merge.
Closes #14487