Repository navigation
fix(gate): negotiate resolve-only gate readiness with runner capabilities - #18496
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AgentTaskGateToolchainRequirementgainsresolve_only: bool(serde default false, omitted from output when false). Inferred gate readiness requirements set it to true, andprobe_argumentsnow carries just the gate program. All existing struct literals were updated withresolve_only: false.resolve_onlyis true or the legacy sentinel is the first probe argument. The legacy branch is marked removable later under Readiness sends the resolve-only sentinel to a runner daemon that predates it; status reports the skewed daemon compatible #18051.GATE_READINESS_RESOLVE_ONLY_CAPABILITYandrunner_optional_capabilities(), a separate list next to the daemon recovery capabilities. It is advertised asrunner_optional_capabilitiesinhomeboy selfidentity and in both daemon/versionresponses.execute_owned) fetches the running daemon's/versionbefore sending any request that contains aresolve_onlyrequirement, and refuses with a retryable RunnerVersionSkew error (gate_disposition=unavailable, stage=readiness_capability, convergence_commands=[homeboy runner refresh-homeboy <runner>]) if the capability is missing. Added aconnection::daemon_version_bodyhelper for the fetch.Verification
cargo fmt --all -- --check: passed on
5ad4a19. Basemain@5476e91advanced toc405a86. 16888 ms; retained gate metadata.nice -n 10 cargo check --workspace --all-targets -j2: passed on
5ad4a19. Basemain@5476e91advanced toc405a86. 207059 ms; retained gate metadata.HOMEBOY_LINT_BASE=5476e91c89a430ac1fc074d696e7d283444e2c5a homeboy --placement l (
HOMEBOY_LINT_BASE=5476e91c89a430ac1fc074d696e7d283444e2c5a homeboy --placement local review lint homeboy --path . --cha…): passed on5ad4a19. Basemain@5476e91advanced toc405a86. 318000 ms; retained gate metadata.repro: none (no repro gate was declared, so these gates do not prove the issue).
CI: pending
Cook run
f3f1f98dd08e1bdf505b9485bff5717cf041f248f3f1f98dd08e1bdf505b9485bff5717cf041f248f3f1f98dd08e1bdf505b9485bff5717cf041f248Evidence
AI disclosure
Tool: Homeboy Cook. Agent: Homeboy (pi). Model: Pi · route roadie/cook-heavy · served gpt-6.1-sol, claude-opus-5-5. Cook time: 18m27s.
Implementation and reviewer documentation were written by the AI, under the direction of the Cook requester. Gates were run by Homeboy. A human reviews before merge.
Closes #18051