Skip to content

fix(gate): negotiate resolve-only gate readiness with runner capabilities - #18496

Merged
chubes4 merged 2 commits into
mainfrom
fix/gate-resolve-only-capability-18051
Nov 18, 2026
Merged

chubes4 merged 2 commits into
mainfrom
fix/gate-resolve-only-capability-18051

Conversation

@chubes4

@chubes4 chubes4 commented Nov 18, 2026

Copy link
Copy Markdown
Member

What changed

  • AgentTaskGateToolchainRequirement gains resolve_only: bool (serde default false, omitted from output when false). Inferred gate readiness requirements set it to true, and probe_arguments now carries just the gate program. All existing struct literals were updated with resolve_only: false.
  • Runner readiness resolves the command on PATH without running it when resolve_only is true or the legacy sentinel is the first probe argument. The legacy branch is marked removable later under Readiness sends the resolve-only sentinel to a runner daemon that predates it; status reports the skewed daemon compatible #18051.
  • homeboy-lab-contract adds GATE_READINESS_RESOLVE_ONLY_CAPABILITY and runner_optional_capabilities(), a separate list next to the daemon recovery capabilities. It is advertised as runner_optional_capabilities in homeboy self identity and in both daemon /version responses.
  • Lab gate transport (execute_owned) fetches the running daemon's /version before sending any request that contains a resolve_only requirement, and refuses with a retryable RunnerVersionSkew error (gate_disposition=unavailable, stage=readiness_capability, convergence_commands=[homeboy runner refresh-homeboy <runner>]) if the capability is missing. Added a connection::daemon_version_body helper for the fetch.
  • Tests: serde round-trip of the new field and an old payload defaulting to false; runner readiness with both the typed field and the legacy sentinel, using a stub program that would leave a marker file if run; the controller refusing a runner without the capability; the identity report advertising the new capability.

Verification

  • cargo fmt --all -- --check: passed on 5ad4a19. Base main@5476e91 advanced to c405a86. 16888 ms; retained gate metadata.

  • nice -n 10 cargo check --workspace --all-targets -j2: passed on 5ad4a19. Base main@5476e91 advanced to c405a86. 207059 ms; retained gate metadata.

  • HOMEBOY_LINT_BASE=5476e91c89a430ac1fc074d696e7d283444e2c5a homeboy --placement l (HOMEBOY_LINT_BASE=5476e91c89a430ac1fc074d696e7d283444e2c5a homeboy --placement local review lint homeboy --path . --cha…): passed on 5ad4a19. Base main@5476e91 advanced to c405a86. 318000 ms; retained gate metadata.

  • repro: none (no repro gate was declared, so these gates do not prove the issue).

  • CI: pending

Cook run
  • Gate 1: tree f3f1f98dd08e1bdf505b9485bff5717cf041f248
  • Gate 2: tree f3f1f98dd08e1bdf505b9485bff5717cf041f248
  • Gate 3: tree f3f1f98dd08e1bdf505b9485bff5717cf041f248

Evidence

  • cargo fmt --all and nice -n 10 cargo check --workspace --all-targets -j2 pass; only warnings already on the base remain. Tests were not run on this host (disk constraint); CI runs them.

AI disclosure

Tool: Homeboy Cook. Agent: Homeboy (pi). Model: Pi · route roadie/cook-heavy · served gpt-6.1-sol, claude-opus-5-5. Cook time: 18m27s.

Implementation and reviewer documentation were written by the AI, under the direction of the Cook requester. Gates were run by Homeboy. A human reviews before merge.

Closes #18051

@chubes4
chubes4 merged commit 6ced09f into main Nov 18, 2026
17 checks passed
@chubes4
chubes4 deleted the fix/gate-resolve-only-capability-18051 branch November 18, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Readiness sends the resolve-only sentinel to a runner daemon that predates it; status reports the skewed daemon compatible

1 participant