Skip to content

fix: (mac_videoplayer)restore previous volume on unmute #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akaps316 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: (mac_videoplayer)restore previous volume on unmute #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ChromiumBasedEditors/lib/src/mac_videoplayer/playercontroller.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ @interface NSPlayerControllerBridge ()
// time slider dragging info
bool m_is_drag;
float m_rate_before_drag;
float m_volume_before_mute;
}
// button callbacks
- (void)onBtnPlayPausePressed:(NSIconPushButton*)sender;
Expand All @@ -39,6 +40,7 @@ - (instancetype)initWithPlayer:(AVPlayer*)player videoView:(NSVideoView*)video_v
m_player = player;
m_video_view = video_view;
m_footer = footer;
m_volume_before_mute = m_player.volume;

// PLAY & PAUSE
// UI button action
Expand Down Expand Up @@ -237,8 +239,12 @@ - (void)setVolume:(CGFloat)value {
}

- (void)toggleMute {
// TODO: restore previous volume on second call
[self setVolume:0];
if (m_player.volume > 0.0) {
m_volume_before_mute = m_player.volume;
[self setVolume:0.0];
} else {
[self setVolume:(m_volume_before_mute > 0.0 ? m_volume_before_mute : 0.5)];
}
}

- (void)stop {
Expand Down