Support runtime configuration of maxWaitTimeInMinutes - #1784
Merged
Conversation
Expose the JMX repair timeout (maxWaitTimeInMinutes) through the existing runtime config endpoint (PATCH /repair-management/v2/config) and the ecctool config command, so operators can tune it without restarting. - Add setMaxWaitTimeInMinutes(int) to DistributedJmxProxyFactory; make the field volatile with a validated setter (rejects <= 0) in the impl - Expose DistributedJmxProxyFactory as a Spring @bean so the REST controller can inject it - Handle the max_wait_time_minutes key in ConfigManagementRESTImpl (validate, apply, and include in the response) - Add --max-wait-time flag to ecctool config and include the key in the PATCH body - Document the new flag in ECCTOOL.md and ECCTOOL_EXAMPLES.md New repairs pick up the value immediately; in-flight repairs keep the timeout captured at task creation. Changes are in-memory only and revert to ecc.yml on restart, consistent with the other runtime-configurable scheduler parameters (#1638).
jwaeab
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the JMX repair timeout (maxWaitTimeInMinutes) through the existing runtime config endpoint (PATCH /repair-management/v2/config) and the ecctool config command, so operators can tune it without restarting.
New repairs pick up the value immediately; in-flight repairs keep the timeout captured at task creation. Changes are in-memory only and revert to ecc.yml on restart, consistent with the other runtime-configurable scheduler parameters (#1638).