Repository navigation
#1160 [Todo] feat: count the characters of the new event name in the quick close modal - #1161
Open
evarisk-kilyan wants to merge 1 commit into
Open
evarisk-kilyan wants to merge 1 commit into
evarisk-kilyan wants to merge 1 commit into
Conversation
… the quick close modal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changements
ActionComm::create(), appelé parcreateFromClone(): au-delà, le nom était coupé et terminé par « … » sans avertissement. Le champ est prérempli avec le nom de l'événement clôturé (jusqu'à 255 caractères), et lemaxlengthne s'applique pas à une valeur posée en JS.maxlengthest retiré : un texte collé reste entier et le compteur montre ce qui dépasse, au lieu d'une coupure silencieuse du navigateur.box-shadow, parce qu'eldy force la bordure en!importantau focus.QuickCloseEventNewLabelCount,QuickCloseEventNewLabelTooLong.css/reedcrm.min.cssetjs/reedcrm.min.jssont recompilés avec lebuild-assets.jsde Saturnemain. Le même build surdevelopintact ne change aucun fichier.Vérifié en local
Dans la Todo, avec l'endpoint intercepté (aucun événement modifié) :
Fichiers modifiés
core/tpl/reedcrm_event_quick_close_modal.tpl.phpjs/modules/event_quick_close.jscss/scss/element/_event-quick-close.scsscss/reedcrm.min.css,js/reedcrm.min.jslangs/fr_FR/reedcrm.lang,langs/en_US/reedcrm.langClose #1160