Skip to content

Fix legalRecompute of ficticious phi #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wsmoses wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix legalRecompute of ficticious phi #2925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions enzyme/Enzyme/GradientUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3974,9 +3974,9 @@ bool GradientUtils::legalRecompute(const Value *val,

auto found = fictiousPHIs.find(const_cast<llvm::PHINode *>(phi));
if (found != fictiousPHIs.end()) {
auto orig = found->second;
if (isa<AtomicRMWInst>(orig))
return false;
if (auto orig = found->second)
return legalRecompute(orig, available, BuilderM, reverse,
legalRecomputeCache);
}

if (phi->getNumIncomingValues() == 0) {
Expand Down Expand Up @@ -4251,6 +4251,16 @@ bool GradientUtils::shouldRecompute(const Value *val,

const Instruction *inst = cast<Instruction>(val);

if (auto phi = dyn_cast<PHINode>(val)) {
auto found = fictiousPHIs.find(const_cast<llvm::PHINode *>(phi));
if (found != fictiousPHIs.end()) {
auto orig = found->second;
if (!orig)
return false;
return shouldRecompute(orig, available, BuilderM);
}
}

if (TapesToPreventRecomputation.count(inst))
return false;

Expand Down
Loading