Repository navigation
Docs + CI for the cargo install path - #180
Merged
Merged
Conversation
fire_seq_search_server 1.0.1 is on crates.io now, so `cargo install` is the primary way to get the server and the README should lead with it. The build-from-source instructions move to a subsection rather than disappearing — they're still the development path. Add an Install workflow that verifies the install path end to end on Linux and macOS. It installs from the *extracted package tarball* rather than `cargo install --path .`: `--path` ignores Cargo.toml's `exclude`, so it would build against files that never ship to crates.io, which is precisely the breakage worth catching now that `tests/` and `*.sh` are excluded. Master + manual only — it's a release build with a bundled SQLite compiled from C, and ci.yml's cargo test + cargo package already gate every PR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fire_seq_search_server1.0.1 is on crates.io now, socargo installis the primary way to get the server. Two changes follow from that.README
Section 2 leads with
cargo install fire_seq_search_serverand notes that it lands onPATHin~/.cargo/bin(plus a heads-up that the first install compiles bundled SQLite, so it takes a few minutes). The Logseq/Obsidian examples drop their./target/release/prefix.Build-from-source moves to a
#### Building from source insteadsubsection rather than being deleted — it's still the development path.fire_seq_search_server/README.md(the crates.io landing page) already had this right from #177 and is untouched.New
InstallworkflowVerifies the install path end to end on ubuntu-latest and macos-14: package, install, then run the binary as a bare command to prove PATH placement and startup.
Two decisions worth review:
cargo install --path ..--pathignoresCargo.toml'sexclude, so it would happily build against files that never ship to crates.io. Now thattests/,*.sh, anddeny.tomlare excluded, that's exactly the class of breakage this job exists to catch. The version is read viacargo metadata+jq, so it needs no bumping.workflow_dispatchonly, not PRs. It's a release-profile build with a bundled SQLite compiled from C — minutes, not seconds — andci.ymlalready gates every PR withcargo teston three platforms plus a verifyingcargo package.--no-verifyon the package step here since the install recompiles the same tree anyway.Verified locally (macOS)
cargo package --locked --no-verify→ 28 files, 286.4 KiB--root→ clean release buildfire_seq_search_server --version→fire_seq_search_server 1.0.1, exit 0Note this workflow tests the source tree's installability, not the published registry artifact — installing from crates.io on a master push would only re-test whatever is already published. A post-publish registry check would be a separate scheduled job.
🤖 Generated with Claude Code