Fix the record button being reported twice and losing its place - #2001
Open
mehranlatifi83 wants to merge 1 commit into
Open
Fix the record button being reported twice and losing its place#2001mehranlatifi83 wants to merge 1 commit into
mehranlatifi83 wants to merge 1 commit into
Conversation
mehranlatifi83
force-pushed
the
fix/talkback-duplicate-record-button
branch
3 times, most recently
from
July 31, 2026 17:32
eb2ecad to
23dc84c
Compare
mehranlatifi83
changed the title
The record button is a container with an icon inside it, and both carry the same description, so screen readers find the button twice at the very same place, once for the container they can act on and once for the icon that only draws it. Recording then fades the container out, and a view left with no alpha at all counts as gone, so a screen reader that was on the button loses its place and jumps to whatever it finds next, the back button or a message. The icon never had that problem because only its parent was faded. Keep the description on the container, which is what is landed on, leave the icon out of what is reported, and fade the button for recording with the least alpha there is, which draws nothing either.
mehranlatifi83
force-pushed
the
fix/talkback-duplicate-record-button
branch
from
August 3, 2026 17:15
23dc84c to
dcc137e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screen readers find the record voice message button twice in the message bar, at the very same place, and lose their place when a recording starts.
The button is a container with an animated icon inside it, and both are given the same description whenever the voice or video mode is set, so the icon that only draws the button is reported next to the container that can be used.
Recording then fades the container out. A view left with no alpha at all counts as gone, so a screen reader that was reading the button has nothing to hold on to and jumps to whatever it finds next, the back button or a message in the chat. The icon never caused that, because recording only fades its parent.
Keep the description on the container, which is the one landed on and acted on, leave the icon out of what is reported, and fade the button for recording with the least alpha there is, which draws nothing either.