fix(serializers): preserve angle-bracket URLs as text - #1466
Merged
Conversation
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
doistbot
reviewed
Aug 11, 2026
doistbot
left a comment
Member
There was a problem hiding this comment.
The PR treats angle-bracket HTTP(S) URLs as plain text when loading stored Markdown into rich-text editors, preventing them from being parsed as links.
Few things worth tightening:
- Consider reusing the existing
remarkDisableConstructsplugin instead of the new AST-walking plugin. Adding'autolink'to itsdisabledConstructslist would disable angle-bracket URL parsing at the micromark level—no AST traversal, source slicing, or regex needed. Since the behavior applies unconditionally, the push should go outside the schema conditionals in that plugin.
I also left one optional follow-up note in the details below.
Optional follow-up note (1)
src/serializers/html/plugins/remark-ignore-angle-bracket-autolinks.ts:12:
visit(tree as Parent, ...)invokes the callback for every node in the AST, then early-returns for non-linknodes after accessing position properties. Every other visitor in this directory uses the typed form (e.g.visit(tree, 'element', ...)) to skip non-matching nodes. Usevisit(tree, 'link', (node, index, parent) => { ... })to avoid the per-node callback overhead on the serialization hot path, which runs on every document load and scales with document size.
rfgamaral
requested review from
a team and
Bloomca
and removed request for
a team
August 11, 2026 18:01
doist-release-bot Bot
pushed a commit
that referenced
this pull request
Aug 11, 2026
## [17.0.1](v17.0.0...v17.0.1) (2026-08-11) ### Bug Fixes * **serializers:** preserve angle-bracket URLs as text ([#1466](#1466)) ([7ecfc21](7ecfc21))
|
🎉 This PR is included in version 17.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Treats angle-bracket HTTP(S) URLs as plain text when loading stored Markdown into rich-text editors. This prevents unsupported Markdown syntax from becoming a link whether or not the link extension is enabled.
Reference
Related to Doist/Issues#20812
PR Checklist
Test plan
Defaultstory underTypist Editor → Rich-textcontentcontrol to<https://duckduckgo.com><https://duckduckgo.com>as plain text rather than a linkMarkdown Outputcontains<https://duckduckgo.com>unchangedDemo