Skip to content

chore: correct GCP references in Azure Container Apps docs#38081

Merged
ava-silver merged 2 commits into
masterfrom
ava.silver/chore/correct-gcp-references-in-azure-container-apps-docs
Jul 10, 2026
Merged

chore: correct GCP references in Azure Container Apps docs#38081
ava-silver merged 2 commits into
masterfrom
ava.silver/chore/correct-gcp-references-in-azure-container-apps-docs

Conversation

@ava-silver

@ava-silver ava-silver commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

What does this PR do? What is the motivation?

Fixes Google Cloud references that were leaking into the Azure Container Apps docs through shortcodes shared with Cloud Run:

  • serverless-init-configure: the DD_API_KEY guidance now says "Container Apps secret" for Container Apps and keeps "Google Cloud Secret" for Cloud Run.
  • Container Apps Node.js sidecar page passed productNames="Cloud Run services"; corrected to "Azure Container Apps".
  • serverless-init-env-vars-sidecar: added the required DD_AZURE_SUBSCRIPTION_ID and DD_AZURE_RESOURCE_GROUP rows for Container Apps, matching the in-container table and the sidecar install steps.

Merge readiness

  • Ready for merge

For Datadog employees:

  • ⚠️ Your branch name MUST follow the <name>/<description> convention and include the forward slash (/).
  • 🤖 New: Comment with /review to run an automated check that catches common issues before a Documentation team member reviews your PR.

AI assistance

Used Claude Code to audit the shared serverless-init shortcodes and apply the fixes.

Additional notes

@github-actions github-actions Bot added the Architecture Everything related to the Doc backend label Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ava-silver

Copy link
Copy Markdown
Contributor Author

/review

@ava-silver ava-silver marked this pull request as ready for review July 9, 2026 18:51
@ava-silver ava-silver requested review from a team as code owners July 9, 2026 18:51
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated review by Claude. AI-generated; verify before acting.

Overall the changes look correct and consistent with the other Azure Container Apps sidecar pages.

One follow-up outside this diff (blocker for this PR's goal): content/en/serverless/azure_container_apps/sidecar/nodejs.md:95 still calls the shortcode with defaultSource="cloudrun":

{{% serverless-init-env-vars-sidecar language="nodejs" defaultSource="cloudrun" %}}

Every other azure_container_apps/sidecar/*.md page uses defaultSource="containerapp". Because the new DD_AZURE_SUBSCRIPTION_ID / DD_AZURE_RESOURCE_GROUP rows added here are gated on defaultSource == "containerapp", they will not appear on the Node.js Azure Container Apps page, and the documented default for DD_SOURCE on that page will incorrectly remain cloudrun. Updating that line to defaultSource="containerapp" is likely required to make this PR's intent take effect.

Reviewed e04a8c9a50549dbf0a7ef6deef1fb61846b1ff2aworkflow run

Comment thread layouts/shortcodes/serverless-init-env-vars-sidecar.html

@estherk15 estherk15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Comment thread layouts/shortcodes/serverless-init-configure.html
@ava-silver ava-silver merged commit 4e0a07b into master Jul 10, 2026
28 checks passed
@ava-silver ava-silver deleted the ava.silver/chore/correct-gcp-references-in-azure-container-apps-docs branch July 10, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants