Skip to content

feat: Allow to use AWS secretsmanager with managed external secrets - #1179

Open
bebold-jhr wants to merge 1 commit into
DataDog:masterfrom
bebold-jhr:feat/allow-aws-secretsmanager-external-secrets
Open

feat: Allow to use AWS secretsmanager with managed external secrets#1179
bebold-jhr wants to merge 1 commit into
DataDog:masterfrom
bebold-jhr:feat/allow-aws-secretsmanager-external-secrets

Conversation

@bebold-jhr

@bebold-jhr bebold-jhr commented Jul 22, 2026

Copy link
Copy Markdown

See also DataDog/terraform-aws-log-lambda-forwarder-datadog#49

What does this PR do?

Allow the use of an AWS secretsmanager with managed external secret.

Motivation

We wanted to use external secrets, but the documentation said that you can only store plaintext secrets.
Also these issues/PRs:

Testing Guidelines

A new test which checks that extraction of the API key works for all three cases

  • DD_API_KEY
  • apiKey
  • plaintext

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@bebold-jhr
bebold-jhr requested review from a team as code owners July 22, 2026 07:25
@litianningdatadog

Copy link
Copy Markdown

@bebold-jhr , just to clarify, datadog-lambda-extension does support AWS secrete manager via env variable DD_API_KEY_SECRET_ARN (ref).

@bebold-jhr

bebold-jhr commented Jul 23, 2026

Copy link
Copy Markdown
Author

@litianningdatadog As far as I'm concerned, the datadog-lambda-extension only supports plaintext and a secret with JSON object having a key called DD_API_KEY. The PR which I linked in the description is still open in that repo which allows the externally managed secrets from secret manager having a key called apiKey. From my perspektive this is also missing here.

@bebold-jhr

Copy link
Copy Markdown
Author

Hi @litianningdatadog,
can you give me feedback on this whether my understand here is wrong (= closing this PR) or if it is a valid case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants