feat: Allow to use AWS secretsmanager with managed external secrets - #1179
Open
bebold-jhr wants to merge 1 commit into
Open
feat: Allow to use AWS secretsmanager with managed external secrets#1179bebold-jhr wants to merge 1 commit into
bebold-jhr wants to merge 1 commit into
Conversation
|
@bebold-jhr , just to clarify, datadog-lambda-extension does support AWS secrete manager via env variable |
OliviaShoup
approved these changes
Jul 22, 2026
Author
|
@litianningdatadog As far as I'm concerned, the datadog-lambda-extension only supports plaintext and a secret with JSON object having a key called |
Author
|
Hi @litianningdatadog, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also DataDog/terraform-aws-log-lambda-forwarder-datadog#49
What does this PR do?
Allow the use of an AWS secretsmanager with managed external secret.
Motivation
We wanted to use external secrets, but the documentation said that you can only store plaintext secrets.
Also these issues/PRs:
Testing Guidelines
A new test which checks that extraction of the API key works for all three cases
Additional Notes
Types of changes
Check all that apply