added themeing support for declarations - #1602
Open
Carlyle-Foster wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
i forgot there's a test suite, the unit tests have already helped me find a few bugs in the semantics tokens code, i should have this wrangled soon enough though |
Contributor
Author
|
|
Contributor
Author
|
at least the tests are passing |
Contributor
Author
the panic in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
both the semantic tokens and the TextMate grammar can now distinguish the initial declarations of variable and constants from their uses. i tried to keep backwards compatibility with existing themes as much as possible, so in some cases where
meta.scopes were being used incorrectly to refer to concrete tokens i kept them but added correct scopes as well (it's also quite possible that my understanding of TextMate naming conventions is just incomplete)