Skip to content

added themeing support for declarations - #1602

Open
Carlyle-Foster wants to merge 3 commits into
DanielGavin:masterfrom
Carlyle-Foster:master
Open

added themeing support for declarations#1602
Carlyle-Foster wants to merge 3 commits into
DanielGavin:masterfrom
Carlyle-Foster:master

Conversation

@Carlyle-Foster

Copy link
Copy Markdown
Contributor

both the semantic tokens and the TextMate grammar can now distinguish the initial declarations of variable and constants from their uses. i tried to keep backwards compatibility with existing themes as much as possible, so in some cases where meta. scopes were being used incorrectly to refer to concrete tokens i kept them but added correct scopes as well (it's also quite possible that my understanding of TextMate naming conventions is just incomplete)

@Carlyle-Foster

Copy link
Copy Markdown
Contributor Author

i forgot there's a test suite, the unit tests have already helped me find a few bugs in the semantics tokens code, i should have this wrangled soon enough though

@Carlyle-Foster

Copy link
Copy Markdown
Contributor Author

keyword_lut_init() in core:odin/tokenizer at line 85 is crashing nondeterministicly when i run tests, but i think that's an unrelated race condition? there's also some warning from analysis.odin:1558:internal_resolve_type_expression()

@Carlyle-Foster

Copy link
Copy Markdown
Contributor Author

at least the tests are passing

@Carlyle-Foster

Copy link
Copy Markdown
Contributor Author

keyword_lut_init() in core:odin/tokenizer at line 85 is crashing nondeterministicly when i run tests, but i think that's an unrelated race condition? there's also some warning from analysis.odin:1558:internal_resolve_type_expression()

the panic in core:odin/tokenizer is indeed a known race condition, not my problem i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant