Add VS Code Dev Container configuration - #209
Open
mandarl wants to merge 4 commits into
Open
Conversation
Added CLAUDE.md with comprehensive development guide including: - Docker development commands and setup - Testing and code quality commands - Database migration workflows - CakePHP 3 architecture overview - Authentication system details - Common pitfalls and solutions Added agents.md as a simple reference pointer to CLAUDE.md. Updated .gitignore to exclude .claude/ directory. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Check if files exist before calling filesize() in both the JSON feed and RSS/Atom feed methods to prevent errors when referenced files are missing from the filesystem. - Added file_exists() check in eventsJson() method (line 297) - Added file_exists() check in feed() method (line 491) - Skip missing files gracefully instead of throwing errors Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
When duplicating an event, check if the source file exists on the filesystem before copying its metadata to the new event. This prevents creating orphaned database records that reference non-existent files. - Added file_exists() check in _afterAdd() method around line 1728 - Skip missing files gracefully instead of creating invalid file records - Follows the same pattern as the RSS feed file existence checks Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add comprehensive Dev Container setup for improved developer experience with VS Code. This provides a one-click development environment with all dependencies, extensions, and debugging pre-configured. Features: - Integrates with existing docker-compose.yml - Pre-configured Xdebug for debugging - Useful PHP/CakePHP VS Code extensions automatically installed - Port forwarding for all development services - Comprehensive documentation Changes: - Added .devcontainer/devcontainer.json with VS Code settings - Added .devcontainer/docker-compose.devcontainer.yml for overrides - Added .devcontainer/README.md with setup and usage instructions - Updated README.md to include Dev Container as recommended option - Updated CLAUDE.md to document Dev Container workflow Benefits: - Faster onboarding for new developers - Consistent development environment across team - No manual setup of PHP, Xdebug, or extensions needed - Integrated debugging experience in VS Code Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
|
This sound more like a local environment config than one specific to deployment. Could this be redone to account for production instead of local dev? |
Member
Author
|
@denzuko - this change is specific to development environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Setting up a local development environment for this CakePHP application currently requires:
This can be time-consuming and error-prone for new developers.
Solution
Implemented a VS Code Dev Container that:
Changes
New Files
.devcontainer/devcontainer.json- Main Dev Container configuration.devcontainer/docker-compose.devcontainer.yml- Dev Container overrides.devcontainer/README.md- Comprehensive documentationUpdated Files
README.md- Added Dev Container as recommended optionCLAUDE.md- Updated development commands sectionFeatures
Automatically Installed Extensions
Pre-configured Services
All services from docker-compose.yml are available:
Debugging Ready
Test Plan
composer testin the integrated terminalbin/cake migrations migrateBenefits
Backward Compatibility
This change is fully backward compatible. Developers can still use:
docker compose upworkflowThe Dev Container is an optional enhancement, not a requirement.
🤖 Generated with Claude Code