Fix OAuth admin groups not being stored - #203
Open
mandarl wants to merge 1 commit into
Open
Conversation
The getGroupsFromUserInfo() method was building the groups array but never returning it, causing all OAuth user groups to be lost. This prevented admin rights from being assigned correctly.
dennis99393
approved these changes
May 12, 2026
There was a problem hiding this comment.
It looks like you committed it by mistake.
| } | ||
| } | ||
| } | ||
| return $result; |
There was a problem hiding this comment.
Fix is correct. $result is built locally and populated in the loop , but never returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix OAuth groups not being stored due to missing return statement in
OpenIDConnectService::getGroupsFromUserInfo(). This prevented admin rights from being assigned correctly when logging in via OAuth.Root Cause
The
getGroupsFromUserInfo()method was building the$resultarray with extracted group names but never returning it, causing all OAuth user groups to be lost.Changes
return $result;statement insrc/Auth/OpenIDConnectService.php:101Test Plan