Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
103 commits
Select commit Hold shift + click to select a range
a7ba095
Generating an environment for which the issue can be recreated
Mar 31, 2026
c50fb9f
WIP
Mar 31, 2026
db1574e
Merging
Jun 4, 2026
456a461
Resovling duplicate config
Jun 4, 2026
785e98b
Adding drunc to the DUNEDAQ_DB_PATH (should get replaced but subject …
Jun 4, 2026
7da158d
Splitting out the failure mode testing into a separate file
Jun 4, 2026
f6f8c62
Making the configs actually pass oks_dump with the DB path
Jun 4, 2026
8859c4b
Remmoving duplicate confs
Jun 4, 2026
234f185
Constructed tests for death on boot and post boot, as well as long FS…
Jun 4, 2026
1bf07c6
Adding death cases
Jun 4, 2026
34d45b9
Clearer conf param names
Jun 5, 2026
c4ead7f
Configs developed, time to test
Jun 5, 2026
cf4ddb8
Remove dupe var definitions
Jun 5, 2026
2a9348a
Fixing the broken session -> OKS var links
Jun 5, 2026
c8fa56e
Included the configs, damned be gitignore
Jun 5, 2026
1323cce
Vars rechecked
Jun 5, 2026
abde856
Moving point of timeout
Jun 5, 2026
468bef9
WIP
Jun 5, 2026
92a5314
Root controller is now marked as in error on timeout, but this needs …
Jun 5, 2026
1aa6d05
Printing the status after marking an error state
Jun 8, 2026
2917d12
Adding log RPC
Jun 8, 2026
899c510
Logs on remote server functional
Jun 8, 2026
6554774
WIP
Jun 8, 2026
b169b22
WIP continuned
Jun 9, 2026
57a8cfa
Logfiles now have a proper format
Jun 9, 2026
0b22161
Docs part 1
Jun 9, 2026
ba65585
Argparse -> click
Jun 10, 2026
6451ede
Constructing integ test, renaming test dir to follow convention
Jun 10, 2026
f0514d0
Integration tests almost running
Jun 10, 2026
e4f82a1
Silly circular dependency
Jun 10, 2026
cc9de6e
First test working
Jun 11, 2026
cc26c52
Test renamed
Jun 15, 2026
f929927
Renaming for clearer implementation, not working as of this commit
Jun 15, 2026
b59e4af
Adding 'no stop on error in batch mode' option to the unfiied shell
Jun 15, 2026
3dd7bd5
Why do multiple tests nopt work!
Jun 15, 2026
9513d86
Once again, bare functionality of the deat on boot nest app config
Jun 15, 2026
4d6ac3f
Next test working
Jun 15, 2026
305a89e
Adding both integ tests to the integtest_list
Jun 15, 2026
e5d91d8
Disabling coverage reporting if integration tests are ran
Jun 15, 2026
50a6335
Commas suck and .sh scripts hate them
Jun 15, 2026
fb0e98a
Updating the relative paths
Jun 15, 2026
b3adf82
Docs and getting the applications to succesfully die post boot
Jun 16, 2026
72bd6e6
Post boot test WIP
Jun 16, 2026
14898e5
Merge branch 'develop' into PawelPlesniak/IncompleteStatefulCommandTr…
Jun 16, 2026
d508f2f
Session is FINALLY getting the top controller name correct, and it is…
Jun 16, 2026
b3e7e61
App dying DOES NOT GET MARKED AS DEAD, but gets put into a disconnect…
Jun 17, 2026
cb101b0
Apps correctly dyign when told to
Jun 17, 2026
2d31ed9
Adding signal handling to the fake_daq_app
Jun 17, 2026
0238d96
Cleanup
Jun 17, 2026
5d8ff8a
Ensuring the sessions do not even attempt to execute stateful command…
Jun 17, 2026
240dc13
Placing session in error state is failing badly
Jun 17, 2026
ac04be0
Next round of test complete
Jun 17, 2026
e7b9907
WIP
Jun 17, 2026
f6b8265
FSM test behaves differently with integration test use vs manual batc…
Jun 17, 2026
7ca462a
Another broken test, to see if it was test speciffic
Jun 17, 2026
2f0e902
Merge branch 'develop' into PawelPlesniak/IncompleteStatefulCommandTr…
Jul 8, 2026
f7457e8
Disabling pytest if a PR is in draft mode
Jul 8, 2026
4301b28
Small modernize
Jul 8, 2026
82f8ed0
Merge branch 'develop' into PawelPlesniak/IncompleteStatefulCommandTr…
Jul 9, 2026
23f72c9
WIP
Jul 9, 2026
960f3ca
First test should be working again, the remainder should be parsed qu…
Jul 9, 2026
8886718
deat on boot nest app done
Jul 10, 2026
a2a418b
Only missing one test, then need to do a LOT of documentation
Jul 10, 2026
2d22271
Needs documentation
Jul 10, 2026
91b1e97
WIP
Jul 13, 2026
3d8c5b7
Removing the reference config
Jul 13, 2026
0da7956
Pytest fix
Jul 13, 2026
9c54136
log_on_server WIP
Jul 16, 2026
1b6e2c0
Done?
Jul 16, 2026
8543da7
Reducing verboisty of an error message
Jul 16, 2026
b430dd1
Small fixes
Jul 16, 2026
67f39c4
Updating the driver script for integration tests
Jul 16, 2026
2e2dcab
Merge branch 'develop' into PawelPlesniak/IncompleteStatefulCommandTr…
Jul 17, 2026
bcf5fe7
Merge complete
Jul 17, 2026
c9a9cc4
Ruff linting
Jul 17, 2026
ddd7860
Merge branch 'develop' into PawelPlesniak/IncompleteStatefulCommandTr…
emmuhamm Jul 21, 2026
2dc0984
Patch changes from integtest development
emmuhamm Jul 21, 2026
99149a6
Clean up minor issues from other tests
emmuhamm Jul 23, 2026
ee14f62
Merge branch 'develop' into PawelPlesniak/IncompleteStatefulCommandTr…
emmuhamm Jul 23, 2026
15d1735
Fix failures
emmuhamm Jul 23, 2026
113b82b
Update src/drunc/integtest/test_failure_mode_death_on_boot_nest_app.py
PawelPlesniak Jul 24, 2026
215f0c8
Adding requested feature to state what command to execute when an app…
Jul 24, 2026
c6717ab
extending tests
Jul 24, 2026
291e6cc
Merge branch 'PawelPlesniak/IncompleteStatefulCommandTransition' of g…
Jul 24, 2026
f23c153
Merge branch 'develop' into PawelPlesniak/IncompleteStatefulCommandTr…
Aug 3, 2026
5e91435
Centralizing the DB path check logic
Aug 3, 2026
125bd59
Adding the relevant docstrings
Aug 3, 2026
f1df46d
Renaming the tests for naming consistency
Aug 3, 2026
4ebe2d0
Documentation and comment addressing
Aug 3, 2026
f3195c3
Making it clearer which application the user should focus on when run…
Aug 3, 2026
e7ee9a7
Update src/drunc/integtest/failure_mode_death_on_boot_nest_app_test.py
PawelPlesniak Aug 3, 2026
2f14250
Simplifying the pytest
Aug 3, 2026
ae81235
Changing dependency from external to internal
Aug 3, 2026
19cadc1
Merge branch 'PawelPlesniak/IncompleteStatefulCommandTransition' of g…
Aug 3, 2026
745f5af
Simplifying logic
Aug 3, 2026
e6ad1ab
Minor updates to logging and testing output
Aug 4, 2026
45cba8d
Correcting pytests, failures associated with bad merges, and resolvin…
Aug 4, 2026
88fb003
Changing excluded nodes to be included
Aug 4, 2026
c4fa1f2
Merge branch 'develop' into PawelPlesniak/IncompleteStatefulCommandTr…
Aug 4, 2026
5fc0a4d
Remvoing resisudal time.sleep
Aug 4, 2026
646bade
Genearlizing the drunc DUNEDAQ_DB_PATH check, and fixing the ruff config
Aug 4, 2026
4535848
Adding a ternary preference
Aug 4, 2026
2050f3c
Adding a clearer comment
Aug 5, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ Unit tests - some tests can't be ran on the CI. This is [documented](https://git
Integration tests - the `daqsystemtest_integtest_bundle` requires a lot of resources, and connections to the EHN1 infrastructure. Check the [cross referenced list](https://github.com/DUNE-DAQ/drunc/wiki#users-with-access-to-clusters-for-running-daqsystemtest_integtest_bundlesh) if you can't run these. The developer needs to run at least the [.](https://github.com/DUNE-DAQ/daqsystemtest/blob/develop/integtest/minimal_system_quick_test.py)

- Unit tests (`pytest --marker`) passed
- [ ] With relevant marker
- [ ] Without marker
- [ ] With relevant marker `_INSERT MAKER NAME HERE_`
- [ ] Relying on the CI workflow
- Integration tests passed
- [ ] Only `daqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.py`
- [ ] Full `daqsystemtest_integtest_bundle.sh`
- [ ] Testing skipped as there are no core code changes in this PR, this only relates to documentation/CI workflows
- [ ] Drunc integration tests pass (`./scripts/drunc_integtest_bundle.sh`)
- [ ] Drunc integration tests pass (`dunedaq_integtest_bundle.sh -r drunc`)

## Final checklist prior to marking this as "Ready for Review"

Expand Down
17 changes: 17 additions & 0 deletions .github/workflows/run_pytest.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,27 @@
name: Run pytest

on:
# Run on any pushes to the main branch which releases are generated from
push:
branches:
- develop
- 'prep-release/**'

pull_request:
branches:
- develop
- 'prep-release/**'
# If taking a PR out of draft mode, run the workflow on the PR event as well
types: [opened, synchronize, reopened, ready_for_review]

# Cancel any running jobs for this same branch if a new commit is pushed
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
install_and_test:
if: github.event.pull_request.draft == false

runs-on: ubuntu-latest

Expand Down
Loading
Loading