Use pytest.fail and short status messages to indicate failures. - #298
Open
eflumerf wants to merge 4 commits into
Open
Use pytest.fail and short status messages to indicate failures.#298eflumerf wants to merge 4 commits into
eflumerf wants to merge 4 commits into
Conversation
bieryAtFnal
approved these changes
Aug 13, 2026
bieryAtFnal
left a comment
Contributor
There was a problem hiding this comment.
These changes look good to me. It will be good to use this model in other regression tests and probably in the integrationtest infrastructure, but I'm reluctant to commit to doing that for fddaq-v5.7.0. But, we should make a note for the next release.
For reference, here is what I see at the end of the MSQT when I bugger the expected fragment sizes and include these changes:
=================================== FAILURES ===================================
_________ test_data_files[MinimalSystem-StandAloneSSH_PM-run_dunerc0] __________
Trigger_Candidate Fragment size check failed. WIBEth Fragment size check failed.
=========================== short test summary info ============================
FAILED minimal_system_quick_test.py::test_data_files[MinimalSystem-StandAloneSSH_PM-run_dunerc0]
========================= 1 failed, 3 passed in 55.40s =========================
and here is what we saw before these changes:
=================================== FAILURES ===================================
_________ test_data_files[MinimalSystem-StandAloneSSH_PM-run_dunerc0] __________
minimal_system_quick_test.py:156: in test_data_files
assert all_ok
E assert False
=========================== short test summary info ============================
FAILED minimal_system_quick_test.py::test_data_files[MinimalSystem-StandAloneSSH_PM-run_dunerc0]
========================= 1 failed, 3 passed in 53.49s =========================
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See title.
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))