Skip to content

Added a second drunc run to the socket_reader_test.py to verify that … - #27

Draft
bieryAtFnal wants to merge 3 commits into
developfrom
kbiery/two_runs_in_integtest
Draft

Added a second drunc run to the socket_reader_test.py to verify that …#27
bieryAtFnal wants to merge 3 commits into
developfrom
kbiery/two_runs_in_integtest

Conversation

@bieryAtFnal

Copy link
Copy Markdown
Contributor

…the underlying code can support multiple runs in a single DAQ session.

Note that this PR is still in a Draft state. It should not be merged until the underlying asiolibs code is updated to support multiple runs in a single DAQ session.

Description

It is a common feature of our integtest/regression tests that they take data twice (two runs). The point of doing that is to verify that the underlying code can handle multiple runs in a single DAQ session. I believe that the current asiolibs code does not support that, and running this modified version of the socket_reader_test demonstrates the problem.

The integtest can be run with pytest -s socket_reader_test.py.

Once the underlying code is updated, we can/should merge this change.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Further checks

@denizergonul

Copy link
Copy Markdown
Contributor

Check if the functionality in the socket reader and/or writer that was unable to handle two runs in the same DAQ session been replaced or modified so that it can handle that situation.

@denizergonul

Copy link
Copy Markdown
Contributor

Moved to Far Future Release since this task is not a near future priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants