Added a second drunc run to the socket_reader_test.py to verify that … - #27
Draft
bieryAtFnal wants to merge 3 commits into
Draft
Added a second drunc run to the socket_reader_test.py to verify that …#27bieryAtFnal wants to merge 3 commits into
bieryAtFnal wants to merge 3 commits into
Conversation
added 3 commits
October 23, 2025 10:23
…the underlying code can support multiple runs in a single DAQ session.
Contributor
|
Check if the functionality in the socket reader and/or writer that was unable to handle two runs in the same DAQ session been replaced or modified so that it can handle that situation. |
Contributor
|
Moved to Far Future Release since this task is not a near future priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…the underlying code can support multiple runs in a single DAQ session.
Note that this PR is still in a Draft state. It should not be merged until the underlying
asiolibscode is updated to support multiple runs in a single DAQ session.Description
It is a common feature of our integtest/regression tests that they take data twice (two runs). The point of doing that is to verify that the underlying code can handle multiple runs in a single DAQ session. I believe that the current
asiolibscode does not support that, and running this modified version of thesocket_reader_testdemonstrates the problem.The integtest can be run with
pytest -s socket_reader_test.py.Once the underlying code is updated, we can/should merge this change.
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)