chore: token policies persisted in DB#967
Draft
Stellatsuu wants to merge 13 commits into
Draft
Conversation
Contributor
|
Hi, can you resolve the conflicts? |
17d010f to
36de8e2
Compare
for more information, see https://pre-commit.ci
Contributor
|
Hi @Stellatsuu, thanks for the fast update 🙂 We have discussed it among the maintainers and we actually would like to hold that PR for now. As it includes DB changes, we see it as a good opportunity to leverage Alembic first. We currently have no migration mechanism and we are close to have multiple installations running diracx (e.g. you are already running it in certification) so it would be easier to have Alembic doing the job. I will open a new issue for Alembic and your work will be held until it's done, and you will just have to rebase your PR and add the alembic script for the migration basically. What do you think? |
This was referenced Jul 9, 2026
Open
Contributor
Author
|
Hi @aldbr, no problem for me :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #524
Changes:
Moved the
dirac_policiesfromTokenPayloadtoRefreshTokensPayloadandAccessTokenPayload.Later, this should be removed from
RefreshTokensPayload.RefreshTokensnow has apoliciescolumn.Manual updates to the already existing DBTable is needed:
ALTER TABLE RefreshTokens ADD COLUMN Policies JSON. It should add NULL by default for existing values.Policiesare added fromall_access_policiesin theexchange_tokenfunction if no policies were found in the DB (e.g, newRefreshToken). Otherwise, they are taken from the DB to create a newAccessTokenPayload.mint_tokenfunction doesn't need to enrich the token anymore since the payloads already have the policies inside them, fromexchange_tokenfunction.enrich_tokenfunction now takes only theAccessTokenPayloadand returns one dict with the policies values.