feat: support global OS prefix#922
Draft
chaen wants to merge 1 commit into
Draft
Conversation
chaen
force-pushed
the
feat_global_os_prefix
branch
from
dbfa5bb to
cbad469
Compare
chaen
force-pushed
the
feat_global_os_prefix
branch
2 times, most recently
from
9d80250 to
7ec3022
Compare
aldbr
force-pushed
the
feat_global_os_prefix
branch
from
7ec3022 to
f997635
Compare
aldbr
requested changes
Jul 7, 2026
Contributor
There was a problem hiding this comment.
How complex would it be to add a unit test against the mock OS DB?
| ) | ||
|
|
||
| # --- OS databases --- | ||
| os_global_prefix = FactorySettings().os_global_prefix |
Contributor
There was a problem hiding this comment.
I guess you can create a variable to encapsulate a FactorySettings instance so that you can reuse it with config_backend_url.
| ) | ||
| """The url for the redis server to manage tasks""" | ||
|
|
||
| os_global_prefix: str = Field( |
Contributor
There was a problem hiding this comment.
From what I understand, the prefix must be lower case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #925
Closes DIRACGrid/DIRAC#8489