Skip to content

Added vertical profile extractor from 3D dfsu files - #994

Open
abja-dhi wants to merge 4 commits into
DHI:mainfrom
abja-dhi:vertical_profile_extractor
Open

Added vertical profile extractor from 3D dfsu files#994
abja-dhi wants to merge 4 commits into
DHI:mainfrom
abja-dhi:vertical_profile_extractor

Conversation

@abja-dhi

@abja-dhi abja-dhi commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

extract_vertical function added as a new method for dataset and dataarray objects.
The base input arguments are xs, ys, and mode. xs and ys are the coordinates of the transect polyline vertices. There are two modes for calling this function: discrete or interpolate. According to the selected mode, the following inputs should be provided:

discrete:

  • layer_min
  • layer_max

interpolate:

  • n_horizontal
  • n_vertical
  • z_min
  • z_max

extract_vertical function added as a new method for dataset and dataarray objects.
@abja-dhi
abja-dhi requested a review from ecomodeller as a code owner August 4, 2026 15:34
@abja-dhi
abja-dhi marked this pull request as draft August 4, 2026 15:35
@abja-dhi
abja-dhi marked this pull request as ready for review August 4, 2026 15:36
@abja-dhi

abja-dhi commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@otzi5300 Could you please review this pull request? @ecomodeller I cannot assign a reviewer to my pull request.

@ecomodeller
ecomodeller requested a review from otzi5300 August 5, 2026 12:11
@ecomodeller
ecomodeller removed the request for review from otzi5300 August 12, 2026 14:44
@ecomodeller

Copy link
Copy Markdown
Member

@abja-dhi FYI, we appreciate your contribution, but it will take some time until we can do a proper review of this.

@abja-dhi

Copy link
Copy Markdown
Contributor Author

@ecomodeller thank you! I totally understand it requires multiple tests to make sure it works as expected in all different scenarios. Please let me know if you found any issues in the script and I'll do my best to modify the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants