Added vertical profile extractor from 3D dfsu files - #994
Open
abja-dhi wants to merge 4 commits into
Open
Conversation
extract_vertical function added as a new method for dataset and dataarray objects.
abja-dhi
marked this pull request as draft
August 4, 2026 15:35
abja-dhi
marked this pull request as ready for review
August 4, 2026 15:36
Contributor
Author
|
@otzi5300 Could you please review this pull request? @ecomodeller I cannot assign a reviewer to my pull request. |
Member
|
@abja-dhi FYI, we appreciate your contribution, but it will take some time until we can do a proper review of this. |
Contributor
Author
|
@ecomodeller thank you! I totally understand it requires multiple tests to make sure it works as expected in all different scenarios. Please let me know if you found any issues in the script and I'll do my best to modify the function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_vertical function added as a new method for dataset and dataarray objects.
The base input arguments are xs, ys, and mode. xs and ys are the coordinates of the transect polyline vertices. There are two modes for calling this function: discrete or interpolate. According to the selected mode, the following inputs should be provided:
discrete:
interpolate: