Skip to content

stocks: add expand_all to stocks interface #5809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emreduzenli wants to merge 6 commits into
base: develop
Choose a base branch
from
+16 −0
Open

stocks: add expand_all to stocks interface #5809

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c95953a
add expand_all to stocks interface
emreduzenli May 19, 2026
2f94975
update changelog
emreduzenli May 19, 2026
7d29717
Merge remote-tracking branch 'origin/develop' into expand-all-stocks
emreduzenli Jul 20, 2026
f252265
Merge branch 'DFHack:develop' into expand-all-stocks
emreduzenli Aug 22, 2026
59fcc8b
adjust height computation
emreduzenli Aug 22, 2026
7af24f4
Merge branch 'DFHack:develop' into expand-all-stocks
emreduzenli Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ Template for new versions:
## New Tools

## New Features
- `stocks`: add button/hotkey for expanding all categories on stocks interface

## Fixes

Expand Down
14 changes: 14 additions & 0 deletions plugins/lua/stocks.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@ local function collapse_all()
stocks.i_height = num_sections * 3
end

local function expand_all()
local num_sections = #stocks.current_type_a_expanded
for idx=0,num_sections-1 do
stocks.current_type_a_expanded[idx] = true
end
stocks.i_height = num_sections * 3

@ab9rf ab9rf Jul 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm uncertain that this is the correct thing to do here, but I also don't understand why collapse_all does the same thing. So if someone could explain this to me, it would help me feel better about approving this change.

@chdoc chdoc Aug 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you were right to be suspicious. stocks.i_height appears to be the total height of the right hand side (in interface lines, 3 per entry). When expanding all entries, the total height of the right inside could be computed as simply as:

Suggested change
stocks.i_height = num_sections * 3
num_items = #stocks.current_type_i_list
stocks.i_height = (num_items + num_sections) * 3

@emreduzenli emreduzenli Aug 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the clarification, I've updated the branch to reflect your suggested way of computing it

end

local function remove_empty()
local empties = {}
for itype,v in ipairs(stocks.storeamount) do
Expand Down Expand Up @@ -52,6 +60,12 @@ function StocksOverlay:init()
key='CUSTOM_CTRL_X',
on_activate=collapse_all,
},
widgets.HotkeyLabel{
frame={t=1, l=0},
label='expand all',
key='CUSTOM_CTRL_Z',
on_activate=expand_all,
},
widgets.HotkeyLabel{
frame={t=2, l=0},
label='remove empties',
Expand Down