Allow label transform functions - #424
Open
jjdelc wants to merge 7 commits into
Open
Conversation
gergness
approved these changes
May 21, 2026
gergness
left a comment
Contributor
There was a problem hiding this comment.
Looks good, consider adding an integration test though?
In particular, it wasn't clear to me whether it will consider "No Data" when looking for the common prefix in trim_common. (I think it does the right thing because we access the labels via Dimension.labels which calls self.all_elements.valid_elements
Also note there are a few failing unit tests because of the internal changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #424 +/- ##
===========================================
- Coverage 100.00% 99.94% -0.06%
===========================================
Files 19 19
Lines 5127 5176 +49
===========================================
+ Hits 5127 5173 +46
- Misses 0 3 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.