Skip to content

Allow label transform functions - #424

Open
jjdelc wants to merge 7 commits into
masterfrom
ZC-3542-allow-labels-transform-syntax-in-tiles
Open

Allow label transform functions#424
jjdelc wants to merge 7 commits into
masterfrom
ZC-3542-allow-labels-transform-syntax-in-tiles

Conversation

@jjdelc

@jjdelc jjdelc commented May 21, 2026

Copy link
Copy Markdown

No description provided.

@gergness gergness left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, consider adding an integration test though?

In particular, it wasn't clear to me whether it will consider "No Data" when looking for the common prefix in trim_common. (I think it does the right thing because we access the labels via Dimension.labels which calls self.all_elements.valid_elements

Also note there are a few failing unit tests because of the internal changes.

@ernestoarbitrio ernestoarbitrio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.94%. Comparing base (26b841d) to head (3164525).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/cr/cube/util.py 84.61% 2 Missing ⚠️
src/cr/cube/dimension.py 97.56% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #424      +/-   ##
===========================================
- Coverage   100.00%   99.94%   -0.06%     
===========================================
  Files           19       19              
  Lines         5127     5176      +49     
===========================================
+ Hits          5127     5173      +46     
- Misses           0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants