Skip to content

Bump prometheus-client from 0.24.1 to 0.25.0 in /app/backend - #8438

Merged
aapeliv merged 1 commit into
developfrom
dependabot/uv/app/backend/prometheus-client-0.25.0
May 4, 2026
Merged

Bump prometheus-client from 0.24.1 to 0.25.0 in /app/backend#8438
aapeliv merged 1 commit into
developfrom
dependabot/uv/app/backend/prometheus-client-0.25.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github May 1, 2026

Copy link
Copy Markdown
Contributor

Bumps prometheus-client from 0.24.1 to 0.25.0.

Release notes

Sourced from prometheus-client's releases.

v0.25.0

What's Changed

Full Changelog: prometheus/client_python@v0.24.1...v0.25.0

Commits

@dependabot dependabot Bot added 1.topic backend This issue relates to the python backend dependencies Pull requests that update a dependency file labels May 1, 2026
@dependabot
dependabot Bot requested a review from aapeliv as a code owner May 1, 2026 00:44
@dependabot dependabot Bot added 1.topic backend This issue relates to the python backend dependencies Pull requests that update a dependency file labels May 1, 2026
@vercel

vercel Bot commented May 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
couchers Ready Ready Preview May 4, 2026 0:35am

Request Review

Bumps [prometheus-client](https://github.com/prometheus/client_python) from 0.24.1 to 0.25.0.
- [Release notes](https://github.com/prometheus/client_python/releases)
- [Commits](prometheus/client_python@v0.24.1...v0.25.0)

---
updated-dependencies:
- dependency-name: prometheus-client
  dependency-version: 0.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/uv/app/backend/prometheus-client-0.25.0 branch from bb8755d to 3ddf498 Compare May 4, 2026 00:33
@aapeliv

aapeliv commented May 4, 2026

Copy link
Copy Markdown
Member

key change for us: prometheus/client_python#1150

@aapeliv

aapeliv commented May 4, 2026

Copy link
Copy Markdown
Member

Opus on whether this interacts with our usage:


No impact. Here's why:

Couchers' usage (app/backend/src/couchers/metrics.py:36-37):

registry: CollectorRegistry = CollectorRegistry()
multiprocess.MultiProcessCollector(registry)

Then generate_latest(registry) is called in create_prometheus_server — that's the unrestricted full-registry path.

What the patch changes:

  1. Adds an opt-in support_collectors_without_names=False constructor param (default off, so behavior is unchanged unless you pass it).
  2. Modifies RestrictedRegistry.collect() — the code path used by restricted_registry(['some_name']).collect() for filtering by name.

Couchers doesn't use either:

  • We construct CollectorRegistry() with no args → new flag defaults to False, identical to old behavior.
  • We never call restricted_registry(...) (grep confirms zero hits) — so the modified code path isn't exercised.
  • generate_latest(registry) walks all collectors directly; the RestrictedRegistry class isn't involved.

So this PR is fully backward-compatible for our setup. The new flag would only become relevant if we ever wanted to support ?name[]=foo style scrape filtering against the multiprocess collector — which we don't currently do.

@aapeliv
aapeliv merged commit 6d43ae2 into develop May 4, 2026
3 of 5 checks passed
@aapeliv
aapeliv deleted the dependabot/uv/app/backend/prometheus-client-0.25.0 branch May 4, 2026 00:35
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

📝 Release Notes

This PR does not need to be included in release notes.

Reason: This PR is a routine dependency update to an internal monitoring library, with no user-facing changes and no meaningful impact on Couchers' current usage according to the discussion.

🤖 Bot Debug Information

Model: couchers.openai.gpt-5.4
Decision: exclude
Reasoning: This PR is a routine dependency update to an internal monitoring library, with no user-facing changes and no meaningful impact on Couchers' current usage according to the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.topic backend This issue relates to the python backend dependencies Pull requests that update a dependency file release notes: not needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant