docs(agent-runtime): converge protected procedural authority - #588
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Valid current-head finding: docs/UML.md currently draws LIFE[external-extension lifecycle] -. caller-supplied fresh authenticated lifecycle snapshot .-> PROC. That conflates two distinct Noema lifecycle domains. #586 consumes ExecutionLifecycle from src/agent-runtime/execution-lifecycle.ts (its JSDoc explicitly calls this the Agent Runtime lifecycle snapshot); it does not consume the Tool Capability external-extension lifecycle represented by LIFE. Please keep the external-extension LIFE node isolated from procedural guidance and model the caller-supplied Agent Runtime execution lifecycle separately. Add an executable regression so future documentation convergence cannot recreate this cross-bounded-context authority arrow. This is a documentation/authority repair finding only; do not change #586 production behavior or promote durable revocation authority.
seonghobae
left a comment
There was a problem hiding this comment.
Second valid current-head finding: docs/TEST_STRATEGY.md removes unrelated protected authority from §13–14 while this PR is scoped to procedural documentation convergence. The patch deletes the explicit test-first failure-triage step/work-conserving rotation and the entire ## 14. Credential-exchange coverage truth contract (including the ban on broad V8-ignore exclusions and exact 100% coverage requirement). None of that is superseded by #585/#586. Preserve the protected section and failure-triage semantics, then keep only the procedural-graph-specific edits in this PR. Add a regression so this docs lane cannot silently erase unrelated coverage authority.
seonghobae
left a comment
There was a problem hiding this comment.
Current-head re-review complete after both repairs. The full nine-file diff now keeps #585/#586 as protected advisory source, keeps ADR 0017 Proposed and activationAuthorized=false, separates Agent Runtime ExecutionLifecycle from Tool Capability external-extension lifecycle, and preserves the unrelated TEST_STRATEGY §13 failure-triage + §14 credential-exchange coverage authority. I found no additional valid source/documentation finding on exact e76be4f8cf9ade4eca4ce462ba10234fa2c63da1. This is COMMENT evidence only, not self-approval; merge still requires the fresh exact-head application CI, reviewer-ci, central Security Scan, and patch-validator-image generations to become terminal passing.
Scope
Repair canonical documentation that still describes merged procedural-graph source as an active/candidate PR. This lane is documentation/test authority only. It must not promote ADR 0017, authorize graph activation, duplicate foreign owner truth, or fabricate release/deployment evidence.
RED / repair lineage
b65539c0db2a2fc3b5af1ed3f35a67f0752e5962added the executable stale-feat(agent-runtime): add advisory procedural graphs and guarded candidate screening #585 documentation regression. Protected source still contained candidate wording; successor commits repaired the canonical graph. Its hosted generation is historical only once the head moved.99547b43dd3421a1854203a7e63969131783019drejects that cross-bounded-context arrow; causaldd8c82c1630707b18622fa84514ac9394d543daaseparates Agent RuntimeExecutionLifecyclefrom external-extension lifecycle;b75b513dc93f6d1c9114b4e2fd468c0c3a76db46corrected the regression fixture to the actual natural-language authority wording.7a7e80fef6df9ffd6c8bf8053e56e01d6bbf4609prevents that erasure; causale76be4f8cf9ade4eca4ce462ba10234fa2c63da1restores the protected §13–14 contract while preserving the procedural-specific updates.Acceptance
ExecutionLifecycle, not the Tool Capability external-extension lifecycle aggregate;activationAuthorized: falseand ADR 0017Proposedremain explicit;