Skip to content

docs(agent-runtime): converge protected procedural authority - #588

Merged
seonghobae merged 17 commits into
mainfrom
docs/procedural-graph-canonical-convergence-20260910
Sep 10, 2026
Merged

seonghobae merged 17 commits into
mainfrom
docs/procedural-graph-canonical-convergence-20260910

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Scope

Repair canonical documentation that still describes merged procedural-graph source as an active/candidate PR. This lane is documentation/test authority only. It must not promote ADR 0017, authorize graph activation, duplicate foreign owner truth, or fabricate release/deployment evidence.

RED / repair lineage

  • Initial exact b65539c0db2a2fc3b5af1ed3f35a67f0752e5962 added the executable stale-feat(agent-runtime): add advisory procedural graphs and guarded candidate screening #585 documentation regression. Protected source still contained candidate wording; successor commits repaired the canonical graph. Its hosted generation is historical only once the head moved.
  • Current-head review found that the UML had incorrectly drawn Tool Capability external-extension lifecycle authority as the source of feat(agent-runtime): gate procedural guidance by execution lifecycle #586 procedural execution lifecycle evidence. Test-first 99547b43dd3421a1854203a7e63969131783019d rejects that cross-bounded-context arrow; causal dd8c82c1630707b18622fa84514ac9394d543daa separates Agent Runtime ExecutionLifecycle from external-extension lifecycle; b75b513dc93f6d1c9114b4e2fd468c0c3a76db46 corrected the regression fixture to the actual natural-language authority wording.
  • Review also found an unrelated deletion of protected TEST_STRATEGY failure-triage and credential-exchange coverage authority. Test-first 7a7e80fef6df9ffd6c8bf8053e56e01d6bbf4609 prevents that erasure; causal e76be4f8cf9ade4eca4ce462ba10234fa2c63da1 restores the protected §13–14 contract while preserving the procedural-specific updates.

Acceptance

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid current-head finding: docs/UML.md currently draws LIFE[external-extension lifecycle] -. caller-supplied fresh authenticated lifecycle snapshot .-> PROC. That conflates two distinct Noema lifecycle domains. #586 consumes ExecutionLifecycle from src/agent-runtime/execution-lifecycle.ts (its JSDoc explicitly calls this the Agent Runtime lifecycle snapshot); it does not consume the Tool Capability external-extension lifecycle represented by LIFE. Please keep the external-extension LIFE node isolated from procedural guidance and model the caller-supplied Agent Runtime execution lifecycle separately. Add an executable regression so future documentation convergence cannot recreate this cross-bounded-context authority arrow. This is a documentation/authority repair finding only; do not change #586 production behavior or promote durable revocation authority.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second valid current-head finding: docs/TEST_STRATEGY.md removes unrelated protected authority from §13–14 while this PR is scoped to procedural documentation convergence. The patch deletes the explicit test-first failure-triage step/work-conserving rotation and the entire ## 14. Credential-exchange coverage truth contract (including the ban on broad V8-ignore exclusions and exact 100% coverage requirement). None of that is superseded by #585/#586. Preserve the protected section and failure-triage semantics, then keep only the procedural-graph-specific edits in this PR. Add a regression so this docs lane cannot silently erase unrelated coverage authority.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head re-review complete after both repairs. The full nine-file diff now keeps #585/#586 as protected advisory source, keeps ADR 0017 Proposed and activationAuthorized=false, separates Agent Runtime ExecutionLifecycle from Tool Capability external-extension lifecycle, and preserves the unrelated TEST_STRATEGY §13 failure-triage + §14 credential-exchange coverage authority. I found no additional valid source/documentation finding on exact e76be4f8cf9ade4eca4ce462ba10234fa2c63da1. This is COMMENT evidence only, not self-approval; merge still requires the fresh exact-head application CI, reviewer-ci, central Security Scan, and patch-validator-image generations to become terminal passing.

@seonghobae
seonghobae marked this pull request as ready for review September 10, 2026 07:03
@seonghobae
seonghobae merged commit 77dd802 into main Sep 10, 2026
18 checks passed
@seonghobae
seonghobae deleted the docs/procedural-graph-canonical-convergence-20260910 branch September 10, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant