ci(actions): isolate pull request concurrency - #550
Merged
Conversation
Adds ADR-0012 recording the architecture decision for unifying Noema into one shared runtime: three candidates were evaluated (shared-package, shared-service, contract-only), and shared-package won on evidence — the only real, current, same-language duplicate is the pydantic-ai Agent-construction wiring independently built in this repository's reviewer/agent.py and naruon's noema_agent.py, not the broader claims the shared-service/contract-only candidates rested on. Implements the ADR's first concrete PR: extracts the AsyncOpenAI -> OpenAIChatModel -> OpenAIProvider -> Agent(...) wiring from reviewer/noema_reviewer into a new packages/noema-core subpackage, plus a shared NOEMA_PERSONA identity fragment. reviewer/ is the sole consumer (self-consumption only); no behavior change — the existing 478-test, 100% coverage/docstring reviewer suite passes unmodified, and noema-core carries its own equivalent 100%/100% suite. Not yet published to an index; both CI (central-review.yml) and local pytest reach it via PYTHONPATH, the same mechanism already used for noema_reviewer itself. naruon's adoption, the identity/verdict-schema contract grafted from the contract-only candidate, and publishing noema-core to an index are scoped as explicit next steps in the ADR, not bundled into this PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
seonghobae
added
the
type: maintenance
ChatGPT Codex Connector
This was referenced Sep 7, 2026
7 tasks
test(ci): forbid docs-only required-gate suppression
10 tasks
…ed-agent-wiring feat(reviewer): extract shared noema-core package (ADR-0014)
…heck-source-rca fix(reviewer): bind failed checks to actionable source evidence
seonghobae
marked this pull request as ready for review
September 7, 2026 14:25
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Own Noema repository-level workflow concurrency and the handoff between hourly commercial readiness and product development. PR supersession cancellation is separated from push/manual run identity; central runner/control-plane authority, contextual-orchestrator routing, quarantine/security and outbound authority remain foreign-owned.
Current exact authority — 2026-09-07 KST
Protected Noema advanced normally through #548 to GitHub-verified
main@e6de53a1c2902cddc09e77a58efb82420cd8f5db. Protected central.github/mainremains GitHub-verified78a4937c684a54ca8e415822c913742f41c6efc4.The predecessor #550 exact
210fd23f001d4b7ff124480fbbed0c26640b3d12was current-main converged against protected #536, but #548 then advanced protected ancestry. Its prior exact-head CI/reviewer success and non-terminal Security/image state are historical only.#550 is now ordinary/non-force semantically converged again. Current exact
f2ec2dc6709814070cc3e3d6932ce280aee966dbis a two-parent commit with first parent current protectedmain@e6de53a...and second parent predecessor #550210fd23.... The tree starts from current protected main and overlays only the 16-path workflow-concurrency delta. Fresh compare is ahead-only withbehind_by=0, merge-base exactly current protected main, and effective diff exactly those 16 paths.This convergence preserves #548 reviewer/source-provenance truth because #548 does not own these 16 paths. It also preserves #536
reviewer-ci.ymlnoema-core package/install/test/smoke wiring while changing only the concurrency group/cancellation expression in that workflow. No central runner/provider/model/security/outbound authority moved into this lane.Fresh exact-head verification
Fresh workflows for
f2ec2dc6...are:ci 34118284754: queued;reviewer-ci 34118284768: queued;Security Scan 34118284779: queued;patch-validator-image 34118284782: pending.Fresh review-thread authority is clean; returned historical findings are resolved. Keep Draft until this unchanged exact head receives terminal-success four-gate evidence and protected/central identities are re-read immediately before normal integration.
#550 remains the workflow-concurrency foundation for overlapping #540. Only after #550 normally integrates may #540 be ordinary/non-force converged while preserving these current workflow semantics together with #540's pinned workerd/esbuild and lock/license delta. No predecessor GREEN transfers.
Summary by CodeRabbit
새 기능
개선 사항
문서