fix(ci): enforce no-heuristic orchestrator/free execution - #538
Closed
seonghobae wants to merge 17 commits into
Closed
fix(ci): enforce no-heuristic orchestrator/free execution#538seonghobae wants to merge 17 commits into
seonghobae wants to merge 17 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #535
This branch proved several no-heuristics defects, but its attempted completion path introduced a temporary self-modifying source writer (
source-fixworkflow/trigger/script), which violates Noema's single-writer lease. That mechanism has now been removed from this branch and a regression (test/no-temporary-self-modifying-writer.test.ts) records the prohibition.The canonical implementation lane is #535. It already owns the broader
orchestrator/freemigration, the process-boundary compatibility ACL for the historicalcontextual-orchestratorbootstrap value, removal of Noema-local inference retry/timeout allocation, request-level ZDR plumbing in the reviewer, severity-independent deterministic gates, and the related documentation/contract changes.Before closing this duplicate lane, the remaining unique workflow/control defects were transferred to #535 as an explicit RED contract in
test/no-heuristic-workflow-authority.test.ts: central-review must requestorchestrator/freedirectly, must not allocate local model timeout/retry policy, must derive ZDR from live repository visibility, hourly OpenCode must fail closed when private-request ZDR cannot be attested, scanner severity/confidence must not become local review authority, and the gateway must not invent a default health deadline.No predecessor check/review evidence from this branch transfers to #535. #535 remains Draft and must satisfy its own exact-head RED→production repair→GREEN and normal protected gates before merge.