-
Notifications
You must be signed in to change notification settings - Fork 1
test(review): consume canonical central OpenCode configuration #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seonghobae
wants to merge
9
commits into
docs/align-llm-owner-guidance
Choose a base branch
from
codex/remove-repo-opencode-config
base: docs/align-llm-owner-guidance
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
88467c0
chore(review): use central OpenCode configuration
seonghobae 0d7f52e
docs(review): stack central OpenCode consumer on governance owner
seonghobae 19d54c3
test(review): narrow central OpenCode consumer contract
seonghobae 09500e4
fix(review): keep OpenCode config owner-controlled
seonghobae 9b19ced
chore(review): restore canonical release and gap writers
seonghobae 53ec33c
chore(review): restack central-config consumer on current governance …
seonghobae 8928037
chore(review): restack #1625 on current #1549
seonghobae 27a59ae
chore(stack): adopt current Naruon governance prerequisite
seonghobae 7bfc7ca
chore(stack): adopt current governance prerequisite
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| """Contract for consuming OpenCode review configuration from the central owner.""" | ||
|
|
||
| from pathlib import Path | ||
|
|
||
|
|
||
| REPO_ROOT = Path(__file__).resolve().parents[2] | ||
|
|
||
|
|
||
| def test_required_review_has_no_repository_local_opencode_configuration() -> None: | ||
| """Repository-local OpenCode JSON must not fork the central review policy.""" | ||
|
|
||
| for relative_path in ("opencode.json", "opencode.jsonc"): | ||
| assert not (REPO_ROOT / relative_path).exists(), ( | ||
| "central OpenCode configuration must remain owner-controlled: " | ||
| f"{relative_path}" | ||
| ) | ||
|
|
||
| agents = (REPO_ROOT / "AGENTS.md").read_text(encoding="utf-8") | ||
| claude = (REPO_ROOT / "CLAUDE.md").read_text(encoding="utf-8") | ||
| for guidance in (agents, claude): | ||
| assert "only `opencode.jsonc`" in guidance | ||
| assert "Graphify" in guidance | ||
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Assert central ownership, not only marker words.
The current assertions pass when a document still contains
only \opencode.jsonc`andGraphify` but no longer states that the central workflow supplies the configuration or that Naruon must not add local configuration. Add explicit ownership and prohibition assertions for both documents.Suggested test strengthening
🤖 Prompt for AI Agents