docs(governance): follow live one-approval merge gate - #1544
Draft
seonghobae wants to merge 12 commits into
Draft
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
PR governance metadata gate is not ready for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
Live merge authority and Naruon's operational guidance had diverged. The active organization ruleset
CWL Central required workflows(id18156473) requires one approving review and review-thread resolution. The active repository rulesetLock default branch(id17214772) independently requires one approving review after the last push, review-thread resolution, and strict required status checks, with no repository-ruleset bypass actor. Current operator guidance must follow those live rules rather than historical zero-approval policy.This PR repairs Naruon operator guidance only. It does not edit organization/repository rulesets, required workflows, branch protection, robot-review workflow code, approval objects, or Application CI behavior.
TDD provenance
48e91f941f5152a88082314d067eb874fd4ad6c3rejects the stale zero-approval instruction token and requires explicit one-approval/non-substitution guidance.276eacfda864f4fd0545bae838bf3598e3becc02,0710b8f7fe9929f867c0446cf476ef5511385f87, and27186f5f30033d18b65d8b56b8604789cec1698falign merge policy and the robot-review skill with the live one-approval rule without modifying the rule itself.e941f04a0310f858da9528db5c834dbf0b8865ferequires the currentdevelopApplication CI PR/push targets.634a76af773759eefa1598b6390e0b0eb1f70dfdand11327e91199bc7c2f6e27775893e3f7e1f9ef2dfalign the policy with live.github/workflows/app-ci.ymland make the regression exact.ca6cda3d8c80236037ba255c8ffe82182a427191requires skipped-required and neutral evidence to remain non-passing and rejects the previous permissive sentence.f93edbfc7009662a727c05b7e727ae1efce95da7makes queued/pending/waiting states explicitly non-passing, keeps skipped-required/neutral evidence non-passing, and limits required-check authorization to exact-current-head terminal success/pass.require_last_push_approval=true; follow-up commits through exact current headf6d4eae54aaa13f156906b0f5dd97e4d067c6dbfpreserve that stronger effective rule in the operator policy and its regression contract.Exact current identity
develop@042b0c70531b229af3acbd0421a2f23098d848b3;f6d4eae54aaa13f156906b0f5dd97e4d067c6dbf;fix/merge-gate-live-approval-policy;Live governance authority
At the latest refetch:
18156473:required_approving_review_count=1, stale reviews dismissed on push, review-thread resolution required;17214772:required_approving_review_count=1,require_last_push_approval=true, review-thread resolution required, strict required status checks, no bypass actors;The May 2026 governance implementation plan remains historical evidence rather than current operator authority. If a canonical ruleset owner changes these values later, the live rulesets must be refetched before changing Naruon guidance again.
Current verification state
Hosted exact-head evidence is incomplete and therefore non-passing. For exact head
f6d4eae54aaa13f156906b0f5dd97e4d067c6dbf:CodeQL PRrun33652841423completed withstartup_failurebefore useful job execution;33652838143, Security Scan33652838100, SAST Semgrep33652838092, Dependency Review33652838125, Bandit33652838209, Docker image validation33652838367, Scorecard33652838148, and OSV33652839047are queued at the latest refetch;Do not churn this documentation head merely to provoke runner scheduling. Central runner/workflow startup repair belongs to the canonical
.githubowner path; Naruon should consume fresh exact-head evidence when those workflows actually execute.Ownership / collision boundary
This lane is independent of externally owned #1543. #1543 changes
.github/workflows/pr-governance.ymlconcurrency behavior andbackend/tests/test_release_governance.py; this PR changes only current merge-gate guidance, the robot-review skill, andbackend/tests/test_merge_gate_live_ruleset_contract.py. It neither copies nor races #1543's workflow delta.Merge boundary
Keep Draft until the unchanged exact head has every applicable required check terminal-success, zero valid unresolved findings/threads, and one qualifying independent approval after the last push as required by the effective live rulesets. No force-push, self-approval, bypass/admin merge, review fabrication/dismissal, approval-count reduction, post-last-push-approval weakening, or other gate weakening.