Skip to content

ci(governance): make PR evaluation cancellation trigger-aware #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 16 commits into
base: develop
Choose a base branch
from
Draft

ci(governance): make PR evaluation cancellation trigger-aware #1543

Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1d24a68
ci(governance): cancel superseded synchronize runs
seonghobae Sep 2, 2026
3d29ce2
fix(concurrency): isolate synchronize runs from review events
seonghobae Sep 2, 2026
75a2fc7
fix(ci): serialize non-synchronize governance evaluations
seonghobae Sep 2, 2026
6ee8357
docs(ci): clean concurrency rationale
seonghobae Sep 2, 2026
5acea7f
test(ci): cover governance concurrency event classes
seonghobae Sep 2, 2026
1258501
test(ci): assert cancellation predicate by trigger
seonghobae Sep 2, 2026
80575af
style(test): format governance concurrency assertions
seonghobae Sep 2, 2026
ef064cb
test(governance): repair concurrency contract regression
seonghobae Sep 3, 2026
133cd6c
test(governance): reproduce cross-event publication race
seonghobae Sep 4, 2026
a656b6b
fix(governance): serialize cross-event gate publication
seonghobae Sep 4, 2026
61ad983
test(governance): require lossless cross-event publication queue
seonghobae Sep 4, 2026
2ea09b5
fix(governance): queue cross-event gate publication losslessly
seonghobae Sep 4, 2026
887d246
ci(governance): remove duplicate local metadata gate
seonghobae Sep 4, 2026
20ca2ca
fix(governance): preserve non-default branch gate
seonghobae Sep 4, 2026
6ae95ae
fix(governance): serialize PR evidence publication
seonghobae Sep 4, 2026
4d84882
docs(governance): state publisher queue precisely
seonghobae Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/pr-governance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,13 @@ permissions:
issues: read

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.event.workflow_run.pull_requests[0].number || github.event.check_run.pull_requests[0].number || github.event.inputs.pr_number || github.run_id }}
cancel-in-progress: false
# Synchronize events get their own PR-scoped group, so a newer push cancels
# only an older synchronize evaluation. Review, workflow_run, check_run, and
# manual recovery events remain in distinct groups and cannot be cancelled by
# a push merely because they share the same PR number.
group: >-
${{ github.workflow }}-${{ github.event.pull_request.number || github.event.workflow_run.pull_requests[0].number || github.event.check_run.pull_requests[0].number || github.event.inputs.pr_number || github.run_id }}-${{ github.event_name == 'pull_request_target' && github.event.action == 'synchronize' && 'synchronize' || github.event_name }}
cancel-in-progress: ${{ github.event_name == 'pull_request_target' && github.event.action == 'synchronize' }}
Comment thread
seonghobae marked this conversation as resolved.
Outdated
Comment thread
seonghobae marked this conversation as resolved.

jobs:
governance:
Expand Down
Loading