Repository navigation
fix(review): enforce KV bearer revocation on the next request - #1329
Merged
seonghobae merged 1 commit intoSep 28, 2026
Merged
seonghobae merged 1 commit into
seonghobae merged 1 commit into
Conversation
Read the current split credentials during authorization so deleted or rotated review tokens stop working on the next request. Keep a stable deployment principal across rotation. Refs #1023
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
merged commit Sep 28, 2026
fcc5a68
into
feat/review-gateway-preseeded-kv
2 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The production review gateway reads split KV bearer credentials once at startup. Deleting or rotating the inference credential leaves the old token accepted until restart. This violates the next-request revocation condition in #1023.
Change
Use the existing
SecurityConfig.bearer_verifierandprincipal_resolverseams to compare each presented token against the current split KV credentials. Missing, equal, or unavailable credentials deny access. The deployment principal remains stable across token rotation. This change does not claim workload-specific identity or admin browser-session revocation; those require separate contracts.Verification
/v1/modelsafter deleting the inference KV credential.git diff --checkpassed.Standard
RFC 7009 describes invalidating revoked credentials; RFC 7662 explains that a resource server relying on revocable tokens must obtain current validity. This PR applies that principle to this gateway's local KV bearer mode; it does not implement an OAuth revocation or introspection endpoint.
Stacked on #1321. Refs #1023.