fix(release): reject lightweight tags before publication resume - #1147
Conversation
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review Please review head 7a37d59 against its stacked base. Automatic review was explicitly skipped for the non-default target; no review exists for this head. |
|
|
b73b5fe
into
feat/canonical-immutable-release-20260902
Change
Contributes the annotated-tag acceptance repair explicitly requested on #1030 at head b0e3d62. The release workflow previously accepted a lightweight tag and resumed publication despite its annotated-release identity contract. The commit-object branch now rejects that tag without moving or replacing it.
The existing executable bash tests now model a genuine annotated tag ref and its commit dereference. A lightweight-tag regression verifies rejection, while existing fresh confirmed-404, valid resume, ancestry and failure cases retain their behavior. No artifact is published by this change.
This is a narrow stacked contribution to the existing release PR; remaining release integration, mandatory SBOM/provenance, hosted validation and consumer adoption still belong to #1030.
Validation: the new lightweight-tag test failed before the workflow repair; all 33 tests in
tests/test_release_workflow_idempotency_contract.pythen passed in 2.20 seconds using the existing project environment.git diff --checkpassed. The tests execute the workflow shell block against a local gh stub; no live release APIs or credentials are used. Local Graphify AST extraction was run; its known virtual-workspace Cargo warning remains tracked in #1144.Expanded exact-head validation: all 119
tests/test_release*.pycontract tests passed in 14.89 seconds at 7a37d59. A fresh Graphify extraction/report at that head contains the new test and expected helper connections; the stale incremental artifact was retained and tracked separately in #1148 rather than treated as successful indexing.