ci(security): run checks on stacked pull requests - #1060
Conversation
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Warning Review limit reachedNext included review available in 37 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Superseded by #1066 — verified by content, not by file overlap. #1066 contains this PR's test function
Deleting Recommend closing this in favour of #1066 once someone with the authority does so — I am commenting only, not closing another session's PR. Note for whoever triages: #1072 does not supersede this one. It only changes Evidence: |
|
Adjudication evidence (host 1 session, 2026-09-06 KST; full report with commands in #1080). Nothing here closes, flips, or retargets anything — the decision is the opener's. Same change as #1066's first commit, not verified as superseded. |
Explicit user-authorized bypass to reduce the stalled infrastructure queue. Reviewed both changed files at 59a8f4e, including the resolved closed-PR admission regression. Security and Quality 34073908489, Scan 34073908487 and SAST 34073908484 succeeded; later Draft-event Quality 34085323868 is skipped, not a success, and compatibility CodeQL 34073908462 remains failed. The expired NIM evidence foundation was already corrected through #1073, not open #1069. Remove the pull_request base filter, retain main-only push and trusted Ready/open admission, and coalesce obsolete PR verification runs by workflow/repository/PR. No formal approval, fresh integrated-head GREEN, scanner bypass or fake status is claimed. Preserve #1060 until complete effective-delta equivalence is independently verified. Normal merge retains all later main runtime repairs and requests new integrated push verification.
|
Closing as fully superseded by merged PR #1066 (merged 2026-09-10), after verifying the previously recorded closure conditions against current protected main 012beaa. The pull_request trigger has no branches filter, while push remains main-only; test_security_workflow_supports_stacked_pull_requests is retained. The current workflow additionally preserves the successor's explicit event types and draft/closed guards. Both affected files are byte-identical between current main and the isolated validation checkout; all 13 tests in tests/test_repository_security_metadata.py passed. This closes the inherited trigger/test delta, not the separate central fork-trust admission or every stacked PR's hosted acceptance. No source branch is deleted and no fork admission control is bypassed. |
Summary
mainRoot cause
GitHub evaluates
pull_request.branchesagainst the PR base branch. Themainfilter therefore left stacked PRs without repository-local CodeQL and Python supply-chain checks.Verification
python -m pytest -q tests/test_repository_security_metadata.py(13 passed)actionlint .github/workflows/security.ymlgit diff --check