-
Notifications
You must be signed in to change notification settings - Fork 0
ci(actions): bound superseded PR runs #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seonghobae
wants to merge
10
commits into
develop
Choose a base branch
from
codex/actions-concurrency-cleanup
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b90a4b5
ci(actions): bound superseded PR runs
seonghobae ba349b5
test(release): require serialized non-dropping delivery queue
seonghobae ef7c5e4
fix(release): serialize immutable package publication
seonghobae 945f554
fix(release): queue release preparation without cancellation
seonghobae 787140f
ci: skip draft pull request jobs
seonghobae 02db6cb
fix(actions): preserve release and rerun evidence
seonghobae cdc95df
fix(actions): cancel only superseded pull request heads
seonghobae ee647c5
ci(actions): consolidate exact coverage jobs
seonghobae 515e11c
test(actions): inspect pull request trigger block
seonghobae 56f1539
docs(changelog): record coverage consolidation
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| """GitHub Actions concurrency contracts.""" | ||
|
|
||
| from pathlib import Path | ||
|
|
||
|
|
||
| ROOT = Path(__file__).resolve().parents[1] | ||
| WORKFLOWS = ROOT / ".github" / "workflows" | ||
| PR_WORKFLOWS = ( | ||
| "commercial-readiness-agent-coverage.yml", | ||
| "controlplane-schema-coverage.yml", | ||
| "openssf-evidence-coverage.yml", | ||
| "pinned-https-coverage.yml", | ||
| "retention-audit-coverage.yml", | ||
| "scan-path-context-coverage.yml", | ||
| "security-process.yml", | ||
| "tests.yml", | ||
| ) | ||
| RELEASE_WORKFLOWS = ("prepare-pypi-release.yml", "publish-pypi.yml") | ||
|
|
||
|
|
||
| def test_pr_workflows_cancel_only_superseded_heads() -> None: | ||
| for name in PR_WORKFLOWS: | ||
| workflow = (WORKFLOWS / name).read_text(encoding="utf-8") | ||
| assert "${{ github.workflow }}-${{ github.repository }}-" in workflow | ||
| assert "github.event.pull_request.number || github.run_id" in workflow | ||
| assert "cancel-in-progress: ${{ github.event_name == 'pull_request' }}" in workflow | ||
| assert ( | ||
| "types: [opened, synchronize, reopened, ready_for_review, converted_to_draft, closed]" | ||
| in workflow | ||
| ) | ||
| assert "github.event.pull_request.draft == false" in workflow | ||
|
seonghobae marked this conversation as resolved.
|
||
|
|
||
|
|
||
| def test_release_workflows_serialize_without_dropping_delivery() -> None: | ||
| for name in RELEASE_WORKFLOWS: | ||
| workflow = (WORKFLOWS / name).read_text(encoding="utf-8") | ||
| assert "group: ${{ github.workflow }}-${{ github.repository }}" in workflow | ||
| assert "github.run_id" not in workflow.split("jobs:", 1)[0] | ||
| assert "queue:" not in workflow.split("jobs:", 1)[0] | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| assert "cancel-in-progress: false" in workflow | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.