fix(a11y): make external-tab context change perceivable without replacing link name - #1104
fix(a11y): make external-tab context change perceivable without replacing link name#1104seonghobae wants to merge 5 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jules Please take the current test-first RED on exact head Minimal production GREEN is deliberately narrow: keep the existing escaped/sanitized URL visible as the link label; retain Run |
요청하신 대로
수정된 내용이 반영된 HEAD SHA는 |
|
@claude Please turn the existing test-only RED into a bounded production GREEN on the live exact head Executable contract: Please change only the reference-link rendering/template and the branch-local Palette journal necessary to describe this as an advisory browsing-context hint. Preserve Run the new contract plus existing dashboard/security tests on the exact descendant. Use a normal descendant only; no force/rebase, self-approval, gate weakening, or source-neutral retrigger. |
해당 오류는 내가 이전에 |
Current scope
The external-reference link keeps its visible escaped URL, adds a visible advisory
↗hidden from the accessibility tree, and appends existing.sr-onlytext(opens in a new tab). The warning therefore augments rather than replaces the visible link name.safeUrl(),esc(),target="_blank", andrel="noopener"remain intact.W3C G200, updated 2026-07-26, recommends advance warning or a hint when a link opens a new window/tab and explicitly classifies the technique as advisory rather than a standalone WCAG conformance requirement. WCAG 2.2 techniques G208/G211 separately preserve the relationship between the visible label and accessible name.
Primary references:
RED → GREEN
4546b4de325b69059b362fd215675e13b24b3f17requires visible URL text + visible↗(aria-hidden="true") +.sr-onlynew-tab warning and rejects the replacementaria-labelpattern.7cef2ecead7517538e60fb8b0b6a12666f308e6bimplements that contract.ec3945e67a0e45623262fae21e7f8987c55cf71dis a two-commit normal descendant; fresh compare from7cef2ece...is ahead 2 / behind 0 /files=[], so the reviewed semantic tree is unchanged.Generated PR #1112 used
aria-label="<visible URL> (opens in a new tab)"and a source-string-only regression. Its valid product intent—advance warning for a target-blank reference—is fully represented here. The implementation-specific replacementaria-labeland generated repository-wide Palette wording are not independent requirements and are intentionally not inherited.Exact-head evidence
On
ec3945e67..., Retention Audit Coverage33845311787completed successfully. Tests33845311746, Pinned HTTPS Coverage33845311694, Scan path context coverage33845311819, Security Process33845311855, Security Scan33845311878, SAST Semgrep33845311863, and OpenSSF Evidence Coverage33845311844are completed/cancelled and therefore non-passing for promotion. No predecessor result is substituted.Delivery Gate
Remain Draft. Do not self-approve, weaken gates, add a source-neutral retrigger, force-update, or transfer predecessor checks.