๐ก๏ธ Sentinel: [HIGH] ๋น ํธ์คํธ๋ช ์ ์ ์ฉํ SSRF ์ฐํ ์ทจ์ฝ์ ํจ์น - #1095
๐ก๏ธ Sentinel: [HIGH] ๋น ํธ์คํธ๋ช
์ ์
์ฉํ SSRF ์ฐํ ์ทจ์ฝ์ ํจ์น#1095seonghobae wants to merge 4 commits into
Conversation
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Current scope
Fix malformed empty-host URLs that could cross the SSRF URL-safety boundary in both the control-plane and CLI validators.
Current exact head:
30fbcdcd345a0de9a597ab1ce03e199068770838againstdevelop@e71d37e7c58118e6764c96ab7c4492fe33eed6f8.The production fix rejects an empty parsed hostname before IP/DNS classification. Fleet TDD added executable coverage in descendant
6109aa9c3dd44355db3b2af2668cd57437731a36for both validators and forhttp://,https://,http://user@, andhttps://user@. The current head30fbcdcdโฆis a non-semantic descendant of that repair (6109aaโฆ โ 30fbcdโฆcompares withfiles=[]), so the test/fix delta is retained without force or destructive restack.Verification state
Keep this PR Draft. Do not transfer predecessor checks.
At current exact head
30fbcdcdโฆ, Tests33737129256, Security Process33737129265, Security Scan33737129440, SAST33737129460, OSV33737130262, Scorecard33737129402, Pinned HTTPS Coverage33737129308, OpenSSF Evidence Coverage33737129410, Scan path coverage33737129355, and Retention Audit Coverage33737129234are queued. No exact-head terminal GREEN has been established yet.The pre-checkout runner-admission evidence has been routed to the canonical
.github#712owner path. Do not merge, mark Ready, or claim release readiness until unchanged-head repository/security evidence is terminal and review state remains clean.