🎨 Palette: 대시보드 'Deploy-blocking' 카드 클릭 필터 기능 추가 by seonghobae · Pull Request #1090 · ContextualWisdomLab/appguardrail

seonghobae · 2026-09-02T14:38:29Z

Product intent

Make the Deploy-blocking summary card a real findings filter with the same pointer, keyboard, and pressed-state semantics as the existing severity filters, without losing keyboard position when the dashboard rerenders.

Review-driven repair

The initial implementation toggled filterBlocking and rerendered the entire dashboard, but the generated card had no stable DOM id. render() already preserves focus by capturing document.activeElement.id and focusing the replacement element with the same id; because this card had none, Enter/Space activation moved keyboard focus to the page after replacement.

The repair was performed test-first and kept the existing focus-restoration mechanism rather than adding a competing state path:

RED/contract commit d8bd9a0e09e451f3b61cc706f9c4bea8171abc9c requires a stable deploy-blocking-card id, the real isDeployBlocking filtering predicate, toggle wiring, aria-pressed, and keyboard activation. The preceding source lacks that stable id and therefore fails this acceptance.
GREEN source commit 95fa6ed394b623d3ec9af4c69fea821b6795c0aa adds only id="deploy-blocking-card" to the generated card, allowing the pre-existing activeId / restoredElement.focus() path to restore focus after replacement.
Current exact head 75987aea4fdb909d8e18c20e343453a357718209 strengthens the regression into executable behavior: a Node DOM harness runs the shipped render() logic with one blocking finding plus non-blocking HIGH/test and WARNING findings, toggles the filter, and verifies the filtered rows, aria-pressed="true", and focus restoration to the newly rendered card.
Both valid Devin review threads are now resolved; no finding was closed without a causal source/test repair.

Current-head evidence

base: develop@e71d37e7c58118e6764c96ab7c4492fe33eed6f8
exact head: 75987aea4fdb909d8e18c20e343453a357718209
GitHub reports the PR open and mechanically mergeable.
Fresh exact-head repository checks are still queued: Tests 33647328885, Security Process 33647328704, SAST 33647328941, Security Scan 33647328983, OSV 33647329799, Scorecard 33647328727, and the evidence-coverage workflows.
Central CodeQL PR run 33647332036 terminated with startup_failure; that control-plane failure is not leaf success evidence and must not be bypassed or inherited from an older head.

Delivery gate

The causal UI fix and executable regression are present, but this PR is not yet merge-ready. Require terminal current-head Tests/security evidence and final current-head review reconciliation. If the Node executable is unavailable in the repository runner, treat that as an explicit test-toolchain defect and repair the workflow/toolchain rather than skipping the behavioral regression.

Anti-Slop delivery check

Intentionality: PASS — the card exists because users need to isolate deployment-blocking findings, and the stable id solely preserves that control through rerender.
Functional completeness: PENDING — executable behavior is encoded, but exact-head CI has not run to completion.
Content fit: PASS — no decorative card, unrelated copy, or template section was introduced.
Resilience: PASS in repaired contract — pointer, Enter/Space, pressed state, filter composition, clear-filter state, and focus restoration are covered; terminal browser/CI evidence is still pending.
Evidence: PENDING — current-head Actions remain queued and CodeQL has a central startup failure.
Product identity: PASS — AppGuardrail’s existing dashboard tokens, information hierarchy, and security findings model are preserved.

대시보드 내의 'Deploy-blocking' 요약 카드를 클릭하여 배포를 차단하는 항목들만 빠르게 필터링할 수 있도록 기능을 추가했습니다. 시각적인 상호작용 피드백을 적용하고 접근성을 고려하여 구현했습니다. 💡 변경 사항: - `Deploy-blocking` 카드에 `role="button"`, `tabindex="0"`, `aria-pressed` 속성 추가 - 마우스 클릭 및 키보드(`Enter`, `Space`) 입력을 통한 필터 토글 기능 구현 - 전역 `Clear filters` 버튼 동작 시 해당 필터 상태도 함께 초기화되도록 수정 - 필터 활성화 시 다른 심각도(Severity) 카드들과 동일한 활성화 스타일(파란색 테두리 및 그림자) 적용

google-labs-jules · 2026-09-02T14:38:32Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

coderabbitai · 2026-09-02T14:38:40Z

Warning

Review limit reached

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 600d599f-0462-42ae-ad28-1c67672649bd

📥 Commits

Reviewing files that changed from the base of the PR and between e71d37e and a3ab25b.

📒 Files selected for processing (3)

.jules/palette.md
scanner/dashboard/index.html
tests/test_dashboard_core.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

devin-ai-integration

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 1 new potential issue.

devin-ai-integration · 2026-09-02T15:16:46Z

  const filtered = ALL
    .map((f,i)=>({f,i}))
    .filter(({f})=> (!filterSev || String(f.severity).toUpperCase()===filterSev))
+    .filter(({f})=> !filterBlocking || isDeployBlocking(f))


📝 Info: Combined filters preserve row identity

The blocking predicate intersects with severity and search filters. Preserved original indices keep each displayed row linked to the correct finding.

Was this helpful? React with 👍 or 👎 to provide feedback.

대시보드 내의 'Deploy-blocking' 요약 카드를 클릭하여 배포를 차단하는 항목들만 빠르게 필터링할 수 있도록 기능을 추가했습니다. 시각적인 상호작용 피드백을 적용하고 접근성을 고려하여 구현했습니다. 💡 변경 사항: - `Deploy-blocking` 카드에 `role="button"`, `tabindex="0"`, `aria-pressed` 속성 추가 - 마우스 클릭 및 키보드(`Enter`, `Space`) 입력을 통한 필터 토글 기능 구현 - 전역 `Clear filters` 버튼 동작 시 해당 필터 상태도 함께 초기화되도록 수정 - 필터 활성화 시 다른 심각도(Severity) 카드들과 동일한 활성화 스타일(파란색 테두리 및 그림자) 적용 - CI 테스트에서 요구하는 `id="deploy-blocking-card"`를 카드 요소에 유지되도록 적용

devin-ai-integration

Devin Review found 1 new potential issue.

devin-ai-integration · 2026-09-03T02:48:20Z

    <p class="sub">${findingsText} · <strong>${blocking}</strong> deploy-blocking (gate ${blocking?'active':'clear'})</p>
    <div class="cards">${cards}
-      <div class="card"><div class="lbl"><span class="dot" style="background:var(--primary)"></span>Deploy-blocking</div><div class="n">${blocking}</div></div>
+      <div id="deploy-blocking-card" class="card" role="button" tabindex="0" aria-label="Filter by Deploy-blocking: ${blocking}" aria-pressed="${filterBlocking}" onclick="filterBlocking=!filterBlocking; document.getElementById('deploy-blocking-card')?.focus(); render();" onkeydown="if(event.key==='Enter'||event.key===' '){event.preventDefault(); this.click();}" style="${filterBlocking ? 'border-color:var(--primary); box-shadow:0 0 0 1px var(--primary); cursor:pointer;' : 'cursor:pointer;'}">


📝 Info: Pre-render focus preserves keyboard position

The pre-render focus() makes the card active before render() captures its ID. Existing restoration then focuses the replacement card.

Was this helpful? React with 👍 or 👎 to provide feedback.

github-project-automation Bot added this to Security Sep 2, 2026

github-project-automation Bot moved this to Backlog in Security Sep 2, 2026

This comment was marked as resolved.

Sign in to view

seonghobae added 3 commits September 3, 2026 00:12

test(dashboard): preserve blocking-card filter and focus contract

d8bd9a0

fix(dashboard): restore blocking-card focus after render

95fa6ed

test(dashboard): execute blocking filter render behavior

75987ae

devin-ai-integration Bot reviewed Sep 2, 2026

View reviewed changes

github-advanced-security Bot found potential problems Sep 3, 2026

View reviewed changes

Comment thread tests/test_dashboard_blocking_filter_contract.py Fixed

devin-ai-integration Bot reviewed Sep 3, 2026

View reviewed changes

Navigation Menu

Uh oh!

🎨 Palette: 대시보드 'Deploy-blocking' 카드 클릭 필터 기능 추가 - #1090

🎨 Palette: 대시보드 'Deploy-blocking' 카드 클릭 필터 기능 추가#1090
seonghobae wants to merge 5 commits into
developfrom
palette-interactive-deploy-blocking-card-12517871394529878792

seonghobae commented Sep 2, 2026 •

edited

Loading

Uh oh!

google-labs-jules Bot commented Sep 2, 2026

Uh oh!

coderabbitai Bot commented Sep 2, 2026 •

edited

Loading

Review limit reached

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration Bot left a comment •

edited

Loading

Uh oh!

devin-ai-integration Bot Sep 2, 2026

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

devin-ai-integration Bot Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

seonghobae commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Product intent

Review-driven repair

Current-head evidence

Delivery gate

Anti-Slop delivery check

Uh oh!

google-labs-jules Bot commented Sep 2, 2026

Uh oh!

coderabbitai Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

seonghobae commented Sep 2, 2026 •

edited

Loading

coderabbitai Bot commented Sep 2, 2026 •

edited

Loading

devin-ai-integration Bot left a comment •

edited

Loading