Skip to content

🎨 Palette: λŒ€μ‹œλ³΄λ“œ 파일 μ—…λ‘œλ“œ UX 및 μ ‘κ·Όμ„± κ°œμ„  #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 2 commits into from
Closed

🎨 Palette: λŒ€μ‹œλ³΄λ“œ 파일 μ—…λ‘œλ“œ UX 및 μ ‘κ·Όμ„± κ°œμ„  #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
668d67f
UX: λŒ€μ‹œλ³΄λ“œ 파일 μ—…λ‘œλ“œ λ²„νŠΌ μ ‘κ·Όμ„± κ°œμ„  및 μ‹œκ°μ  ν”„λ‘μ‹œ 적용
seonghobae Sep 2, 2026
5591191
UX: λŒ€μ‹œλ³΄λ“œ 파일 μ—…λ‘œλ“œ λ²„νŠΌ μ ‘κ·Όμ„± κ°œμ„  및 μ‹œκ°μ  ν”„λ‘μ‹œ 적용
seonghobae Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,7 @@
## 2026-08-12 - Skip to Content Accessibility
**Learning:** Screen reader and keyboard-only users experience significant friction when forced to navigate through repetitive header controls on every page load.
**Action:** Keep a visible-on-focus skip link as the first interactive element, target a programmatically focusable main container, and give the focused link a high-contrast outline.

## 2026-09-02 - Proxy Button Label-in-Name
**Learning:** When replacing native UI elements with proxy elements (like buttons for file inputs), if the proxy button's visible text perfectly describes the action, do not add a redundant `aria-label`. Avoid duplicate accessible names between the proxy and the visually hidden native element.
**Action:** Ensure label-in-name principles are followed and update corresponding UI contract tests to match the new markup.
4 changes: 3 additions & 1 deletion scanner/dashboard/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@
<span class="logo"></span><span class="brand">AppGuardrail</span>
<span class="spacer"></span>
<span class="meta" id="src">no findings loaded</span>
<input type="file" id="file" accept="application/json,.json" aria-label="Upload findings file" style="margin-left:12px">
<button type="button" id="header-browse" class="primary-action" style="margin-left:12px">Upload findings file</button>
<input type="file" id="file" accept="application/json,.json" hidden>
</header>
<p id="findings-summary" class="sr-only" role="status" aria-live="polite" aria-atomic="true"></p>
<main id="app" tabindex="-1"></main>
Expand Down Expand Up @@ -325,6 +326,7 @@ <h1>Dashboard</h1>
}

const fileInput = document.getElementById('file');
document.getElementById('header-browse').addEventListener('click', () => fileInput.click());
fileInput.addEventListener('change', () => {
const selectedFile = fileInput.files?.[0];
fileInput.value = '';
Expand Down
2 changes: 1 addition & 1 deletion tests/test_dashboard_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def test_dashboard_rows_are_keyboard_accessible():
assert 'tabindex="0" role="button"' in html
assert 'title="View details for finding"' in html
assert "tbody tr:focus-visible" in html
assert "aria-label=\"Upload findings file\"" in html
assert ">Upload findings file</button>" in html
assert "aria-label=\"Search findings\"" in html
assert "aria-label=\"Filter by severity\"" in html
assert "tr.addEventListener('keydown'" in html
Expand Down
Loading