Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,7 @@
## 2024-11-20 - Optimize multiple tuple generation from a single collection
**Learning:** `build_rule_metadata` derives exactly two collections, `owasp` and `cwe`, from the same references. Replacing its two generator traversals with one explicit loop reduces element visits from about 2N to N. Both versions remain O(N), so this is a constant-factor optimization rather than an asymptotic complexity improvement.
**Action:** Combine repeated traversal when fixed derived collections share one source, while preserving ordering and classification semantics. Benchmark the production hot path before claiming a material wall-clock improvement.

## 2026-09-03 - Measure reference deduplication before making performance claims
**Learning:** `dict.fromkeys(generator)` and an explicit dictionary loop are both insertion-ordered, hash-based O(N) deduplication. Replacing one with the other may change constant factors, but it does not remove an O(N²) list algorithm because no such list algorithm existed here. A result from one interpreter, machine, or synthetic workload is not enough to support a general percentage claim.
**Action:** Preserve first-seen ordering and filtering semantics. Treat the explicit-loop change as a performance candidate until a reproducible benchmark on the exact code and representative AppGuardrail workloads demonstrates a material improvement; do not publish a percentage or asymptotic claim without that evidence.
21 changes: 10 additions & 11 deletions appguardrail_core/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,10 @@ def as_dict(self) -> dict[str, Any]:

def extract_public_references(message: str) -> tuple[str, ...]:
"""Extract OWASP, CWE, and CVE references already embedded in rule copy."""
return tuple(
dict.fromkeys(
" ".join(match.group(1).split())
for match in REFERENCE_RE.finditer(message or "")
)
)
seen = {}
for match in REFERENCE_RE.finditer(message or ""):
seen[" ".join(match.group(1).split())] = None
return tuple(seen)
Comment on lines +109 to +112

@devin-ai-integration devin-ai-integration Bot Sep 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: First-seen ordering remains stable

Reassigning duplicate dictionary keys does not move them on supported Python versions. Both loops preserve the prior ordering, normalization, and falsy-reference filtering.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.



def _category_for_references(references: tuple[str, ...], fallback: str) -> str:
Expand Down Expand Up @@ -174,8 +172,9 @@ def validate_rule_metadata(metadata: RuleMetadata | dict[str, Any]) -> list[str]


def _merge_references(*groups: tuple[str, ...]) -> tuple[str, ...]:
return tuple(
dict.fromkeys(
reference for group in groups for reference in group if reference
)
)
seen = {}
for group in groups:
for reference in group:
if reference:
seen[reference] = None
return tuple(seen)
Loading