-
Notifications
You must be signed in to change notification settings - Fork 0
⚡ Bolt: 최적화: 제너레이터 오버헤드 감소를 위한 명시적 딕셔너리 사용 #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
seonghobae
wants to merge
2
commits into
develop
from
bolt/optimize-reference-deduplication-11910401350183104503
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -106,12 +106,10 @@ def as_dict(self) -> dict[str, Any]: | |
|
|
||
| def extract_public_references(message: str) -> tuple[str, ...]: | ||
| """Extract OWASP, CWE, and CVE references already embedded in rule copy.""" | ||
| return tuple( | ||
| dict.fromkeys( | ||
| " ".join(match.group(1).split()) | ||
| for match in REFERENCE_RE.finditer(message or "") | ||
| ) | ||
| ) | ||
| seen = {} | ||
| for match in REFERENCE_RE.finditer(message or ""): | ||
| seen[" ".join(match.group(1).split())] = None | ||
| return tuple(seen) | ||
|
|
||
|
|
||
| def _category_for_references(references: tuple[str, ...], fallback: str) -> str: | ||
|
|
@@ -174,8 +172,9 @@ def validate_rule_metadata(metadata: RuleMetadata | dict[str, Any]) -> list[str] | |
|
|
||
|
|
||
| def _merge_references(*groups: tuple[str, ...]) -> tuple[str, ...]: | ||
| return tuple( | ||
| dict.fromkeys( | ||
| reference for group in groups for reference in group if reference | ||
| ) | ||
| ) | ||
| seen = {} | ||
| for group in groups: | ||
| for reference in group: | ||
| if reference: | ||
| seen[reference] = None | ||
| return tuple(seen) | ||
|
Comment on lines
+175
to
+180
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Info: Reference semantics remain equivalent
Duplicate assignment retains each key's first position.
tuple(seen)therefore preserves normalization, ordering, and deduplication from the prior implementation.Was this helpful? React with 👍 or 👎 to provide feedback.