-
Notifications
You must be signed in to change notification settings - Fork 0
⚡ Bolt: stats::na.omit() 사용 배제를 통한 결측치 카운트 로직 최적화 #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 4 commits
98d4897
3b5f6b7
5abc487
39fec12
3063419
e7d4536
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,3 +24,4 @@ | |
| ^\.jules(/.*)?$ | ||
| ^\.trivyignore\.yaml$ | ||
| ^trivy\.yaml$ | ||
| ^\.markdownlint\.json$ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "MD013": false, | ||
| "MD022": false, | ||
| "MD041": false | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,7 +83,7 @@ surveyFA <- function( | |
| response_data <- as.data.frame(data) | ||
| response_data <- | ||
| response_data[, vapply(response_data, function(column) { | ||
| nunique <- length(unique(stats::na.omit(column))) | ||
| nunique <- sum(!is.na(unique(column))) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📝 Info: Regression guard pins the pre-refactor idiom The category-count guard in test-optimization-equivalence.R still pins Was this helpful? React with 👍 or 👎 to provide feedback. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📝 Info: na.omit replacement is numerically equivalent Rewriting Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| nunique >= 2L | ||
| }, logical(1L))] | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
전역 규칙 비활성화의 가정과 위험을 PR 요약에 기록하세요.
이 설정은
MD013,MD022,MD041를 전역으로 비활성화합니다..github/workflows/code-quality.yml:30-33의markdownlint-cli2단계에서 긴 줄, 제목 주변 공백, 첫 번째 H1 누락 검사가 모두 적용되지 않습니다. PR 요약에 이 범위와 품질 게이트 약화 위험을 명시하세요. 가능하면 필요한 파일 또는 규칙으로 범위를 제한하세요.As per coding guidelines: 커밋 또는 PR 요약에 가정과 위험을 문서화해야 합니다.
🤖 Prompt for AI Agents
Source: Coding guidelines