fix(validation): preserve representable recovery metrics - #488
Draft
seonghobae wants to merge 228 commits into
Draft
fix(validation): preserve representable recovery metrics#488seonghobae wants to merge 228 commits into
seonghobae wants to merge 228 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation Evidence landing vehicle
Protected base:
main@1bc02f580cf48e1d39da239f0e818453437c31c3. Current exact head:fe89c43803136ab979912fffa636d2a4f169a73e.This Draft remains the TEPP Validation Evidence numerical/artifact-admission vehicle. Earlier bias/RMSE/Monte Carlo/SE-aware acceptance/Wilson/matching/serde-projection lineages remain in ancestry, executable contracts,
CHANGELOG.d/,docs/research/, and the product/technical gap baseline. No valid predecessor delta is discarded.Current causal finding — exact-count all-covered near-one rounding
The preceding inexact-count work correctly repaired all-covered Wilson behavior above binary64's exact-integer range and added subnormal-scale edge coverage. Fresh review found a separate defect on the exactly representable count path.
For an all-covered sample the same Wilson score endpoint is
L = n / (n + z²) = 1 - z² / (n + z²). Withn = 1and representedz = 0x1.0000000000001p-27, binary64 multiplication yieldsz² = 0x1.0000000000002p-54. The correctly rounded represented-input lower endpoint is0x1.fffffffffffffp-1(next_down(1.0)). The predecessor formedn + z²first; that addition rounded back to1.0, son / (n + z²)emitted false exact1.0and erased a representable finite-sample miss mass.Public RED
e0c4ec81bb455d230259489dc71e23fe33704b1dfixes that exact bit-level contract. Causal repairc9dcb9df363999bbcbb6fffdc8b6a6d9ae5e762ckeeps ordinary direct exact-count evaluation but, only when it has collapsed to exact1.0while representedz² > 0, subtracts the algebraically equivalent miss fractionz² / (n + z²). Boundary reinforcement6140080d2257d0550be479d71371d70e2255c3d0fixesz = 2^-28,z² = 2^-56, where the miss mass is genuinely below binary64 resolution and exact1.0must remain admissible. Changelog09ebb482851fe7836e738a74395e6424621da9bf; research/currentfe89c43803136ab979912fffa636d2a4f169a73e.The concurrent edge-only commit
ccb75e812988c969206177e4876c7abe9944bfd5is retained: it covers an inexact durable countn = 2^53 + 1with a positive subnormal representedz²whose quotient bynis below binary64 range, so the correctly represented all-covered lower endpoint remains exact1.0.Prior Wilson/provenance repairs retained
The exact-count/proportion, complement-symmetry, durable
u64, denominator-scale, and all-covered extreme-zlineages remain in ancestry. In particular, inexact-count extreme-zRED059ce70d3dd497f486214137bca6a1f1b2e8b3cd, boundary repair0f4783929b8d067eecb91696e1ad5761cd315b1e, single-writer cleanup8e2058f2fc6ab42af8f732f03e7ae1dcee3e873d, exact-oracle correction93d5d2089db1fcf4c6167930adb362333a2ed809, changelog correction43b6562c4c2ad3af51970040c127c784cccff228, and research predecessorb03a719d29e20d6cc4f9b70705ee1aa6e48db543remain valid ancestry.The current repair does not claim global correct rounding for every arbitrary Wilson rearrangement. It closes the demonstrated false exact-one state for exactly representable counts while preserving the correctly rounded exact-one state below binary64 resolution.
Owner boundary
This is TEPP Validation Evidence provenance/projection policy around the canonical Wilson producer in
validation_core. It is not reusable static psychometric estimation, does not move Longitudinal Modeling composition, does not copy mutable fast-mlsirm source, and does not consume an unreleased contextual-orchestrator contract.coverage.rsremains the single Wilson writer; durable evidence carriers consume it rather than duplicate arithmetic.Wilson (1927) remains the primary score-interval source. IEEE 754-2019 and ISO/IEC 60559:2020 remain published active floating-point standards; IEEE P754 is an active revision project, not a published replacement.
Merge bar
Exact head
fe89c43803136ab979912fffa636d2a4f169a73eremains Draft. Every source mutation invalidates predecessor workflow/review evidence. Fresh hosted Rust, documentation, security, SAST/supply-chain, owned line/branch coverage, resolved current-head review threads, and a qualifying independent current-head approval are required.mergeable=truealone is not GREEN. No self-approval, force push, destructive rebase, gate weakening, or routine admin bypass.