feat(ui): add legal employer history read states - #150
Draft
seonghobae wants to merge 8 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible HRIS gap
Employee Profile needs a governed way to explain which legal employer is visible for an Employment at an explicit business-time / system-knowledge coordinate without collapsing legal employer into Position or Assignment. This dependency-first child is presentation/interaction only: it does not invent legal-employer persistence, mutate Employment or Organization truth, authorize payroll/statutory actions, or import a foreign service table.
Parent #130 owns the shared protected-read interaction state contract. Active backend PR #141 separately owns the authoritative bitemporal Employment → employing legal Organization relationship and remains unmerged; this UI child does not present #141 as protected-main truth or transfer its checks/reviews.
Contract-first RED → root repair
Contract head
b954b6330f5542b8c1272d4e2317c5ebf108e990contained the focused accessibility/privacy contract and exact-head workflow but intentionally lacked the production state module. Hosted run33219185795, job99009424985, checked out and proved that exact SHA, configured Node24.19.0, then failed at the focused contract withERR_MODULE_NOT_FOUNDforapps/hr-workspace/legal-employer-history-state.js. That is the realistic RED boundary.The smallest root repair adds the governed presentation module, matching Storybook states, existing-token CSS, traceability, and accessibility doctoring. The implementation preserves bounded
idle / loading / ready / empty / denied / stale / scopeBlocked / errorstates; purpose-bound read-only semantics; effective-time/system-recorded-time explanation; legal-employer independence from Position/Assignment; actionable empty/stale/scope/error copy; PII/identifier/legal-tax-payroll/credential minimization; and own-key fail-closed handling forconstructor,toString, and__proto__. It does not add a writer or consequential-decision authority.Exact-current-head GREEN
Current head:
cfab4d70c38eccd5fd528a2314d1346602c405f7.Recorded base/parent: #130
feat/hr-workspace-protected-read-state@68896baa692ecf6fec8f21cfe5d981440be6071c.HR Workspace Legal Employer History State Qualityrun33286022706, job99189253498, is terminal GREEN on this exact head. The runner proved the exact checkout, used Node24.19.0, passed all five focused accessibility/privacy/fail-closed regressions, reportedlegal-employer-history-state.jsand all measured production at 100.00% line / 100.00% branch / 100.00% function coverage, and proved a clean checkout.This is focused stack-local evidence only. It does not transfer parent/backend/default-branch checks or approvals and does not make the child merge-ready before its dependency chain integrates.
Figma / Storybook authority
Fresh Figma metadata from
Orgmetra Baseline(xu1ZK1zmtFcDep95R8oE9O) confirms Storybook Inventory node1:64still enumeratesTimeline,EmptyState,ErrorState,PermissionDenied, and the requireddefault / hover / focus / disabled / loading / validation-error / read-only / high-risk-confirmationvocabulary. The Storybook slice correlates to node1:64, reuses existing design tokens and visible:focus-visiblebehavior, and preserves a 44px minimum action target rather than introducing a parallel design system.Stack / governance
Current #130 head is c92749c (PR #130 remains open and unmerged). Keep Draft. Process #53 then #130 first. After those actually integrate, retarget/revalidate this child against fresh protected
develop, reconcile intervening Employee Profile/API truth and then-current legal-employer backend truth, then rerun every applicable browser/accessibility/Foundation/Recovery/SAST/Security/central workflow on one new exact head. No predecessor evidence transfers. Do not self-approve, use routine administrator bypass, race another writer, or mutate dedicated-writer dependencies.