feat(ui): add governed Position reporting review states - #137
Draft
seonghobae wants to merge 4 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible interaction gap
The shared HR Workspace protected-read interaction owner #130 provides loading/disabled/error/read-only/focus semantics, while Position reporting backend ownership is already separated across #94 (bitemporal reporting snapshot), #95 (human review evidence), #106 (durable reporting persistence), and #133 (descriptive span-of-control evidence). This dependency-first Orgmetra-only child adds the missing workflow-specific UI proof that a reporting-line proposal is a high-impact human review rather than an immediate Position mutation.
The UI does not import unmerged backend packages, create a second reporting mutation owner, read foreign application tables, expose worker PII, or grant employment-decision authority.
RED → implementation → exact-head GREEN
RED contract head:
fbeddab51d07f19753fc057e22992674590ccff3.HR Workspace Position Reporting Review State Qualityrun33116279543completed failure on that exact contract head before the production owner existed. The regression importedapps/hr-workspace/position-reporting-review-state.js, which was intentionally absent. That is the intended first causal boundary; the later implementation does not weaken the test.Current exact head:
0538821f810db7344fdcc0cc46d7ef75def43c87.Recorded GitHub base: #130 branch
feat/hr-workspace-protected-read-state@b3b30058a79174000919d566fbbb1fdad80c62bf.Current parent #130 head:
c92749cf5889a39de1ba8036742f96fd3451f459.Exact-current-head
HR Workspace Position Reporting Review State Qualityrun 33213066619, job 98990527663, is terminal GREEN on this exact head. The dedicated contract is the only current named check, and it passes. Current exact-head review state is 0 unresolved thread(s), with no APPROVED review record. This remains Draft stack-local evidence; parent checks/reviews do not transfer.Dependency discipline
The child retains the recorded GitHub base until the parent is integrated. Keep Draft and process #53 → #130 first. Parent checks/reviews never transfer. #94/#95/#106/#133 remain the separate Position-reporting snapshot/review/persistence/structural-evidence owners; this child owns presentation/interaction only. After #130 actually integrates, retarget/revalidate this child against fresh
develop, reconcile intervening HR Workspace/reporting changes, and rerun every applicable browser/accessibility/Foundation/Recovery/SAST/Security and central required workflow on one resulting exact head.Do not treat UI confirmation as authoritative reporting mutation or employment-decision authority, self-approve, use routine administrator bypass, race another lifecycle writer, transfer predecessor evidence, or mutate another dedicated-writer repository.